From: David Gibson <david@gibson.dropbear.id.au>
To: alex.williamson@redhat.com, pbonzini@redhat.com
Cc: aik@ozlabs.ru, David Gibson <david@gibson.dropbear.id.au>,
qemu-ppc@nongnu.org, qemu-devel@nongnu.org, mst@redhat.com
Subject: [Qemu-devel] [PATCH 05/11] pci: Introduce helper to retrieve a PCI device's DMA address space
Date: Tue, 14 May 2013 19:13:51 +1000 [thread overview]
Message-ID: <1368522837-20747-6-git-send-email-david@gibson.dropbear.id.au> (raw)
In-Reply-To: <1368522837-20747-1-git-send-email-david@gibson.dropbear.id.au>
A PCI device's DMA address space (possibly an IOMMU) is returned by a
method on the PCIBus. At the moment that only has one caller, so the
method is simply open coded. We'll need another caller for VFIO, so
this patch introduces a helper/wrapper function.
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/pci/pci.c | 9 ++++++++-
include/hw/pci/pci.h | 1 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index 39085d8..e7a9735 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -811,7 +811,7 @@ static PCIDevice *do_pci_register_device(PCIDevice *pci_dev, PCIBus *bus,
}
pci_dev->bus = bus;
- dma_as = bus->iommu_fn(bus, bus->iommu_opaque, devfn);
+ dma_as = pci_iommu_as(pci_dev);
memory_region_init_alias(&pci_dev->bus_master_enable_region, "bus master",
dma_as->root, 0, memory_region_size(dma_as->root));
memory_region_set_enabled(&pci_dev->bus_master_enable_region, false);
@@ -2233,6 +2233,13 @@ static void pci_device_class_init(ObjectClass *klass, void *data)
k->props = pci_props;
}
+AddressSpace *pci_iommu_as(PCIDevice *dev)
+{
+ PCIBus *bus = PCI_BUS(dev->bus);
+
+ return bus->iommu_fn(bus, bus->iommu_opaque, dev->devfn);
+}
+
void pci_setup_iommu(PCIBus *bus, PCIIOMMUFunc fn, void *opaque)
{
bus->iommu_fn = fn;
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 6ef1f97..21e2132 100644
--- a/include/hw/pci/pci.h
+++ b/include/hw/pci/pci.h
@@ -402,6 +402,7 @@ void pci_device_deassert_intx(PCIDevice *dev);
typedef AddressSpace *(*PCIIOMMUFunc)(PCIBus *, void *, int);
+AddressSpace *pci_iommu_as(PCIDevice *dev);
void pci_setup_iommu(PCIBus *bus, PCIIOMMUFunc fn, void *opaque);
static inline void
--
1.7.10.4
next prev parent reply other threads:[~2013-05-14 9:14 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-14 9:13 [Qemu-devel] [0/11] RFC: VFIO and guest side IOMMUs, version 3 David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 01/11] iommu: Fix compile error in ioapic.c David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 02/11] pci: Don't del_subgregion on a non subregion David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 03/11] pci: Rework PCI iommu lifetime assumptions David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 04/11] pci: Use AddressSpace rather than MemoryRegion to represent PCI DMA space David Gibson
2013-05-14 9:13 ` David Gibson [this message]
2013-05-14 9:13 ` [Qemu-devel] [PATCH 06/11] memory: Sanity check that no listeners remain on a destroyed AddressSpace David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 07/11] vfio: Introduce VFIO address spaces David Gibson
2013-05-14 16:53 ` Alex Williamson
2013-05-15 1:18 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 08/11] vfio: Create VFIOAddressSpace objects as needed David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 09/11] memory: Add iova to IOMMUTLBEntry David Gibson
2013-05-14 16:53 ` Alex Williamson
2013-05-15 3:51 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-14 21:22 ` [Qemu-devel] " Paolo Bonzini
2013-05-14 9:13 ` [Qemu-devel] [PATCH 10/11] memory: Add iommu map/unmap notifiers David Gibson
2013-05-14 17:15 ` Alex Williamson
2013-05-14 21:02 ` Paolo Bonzini
2013-05-14 21:23 ` Paolo Bonzini
2013-05-15 1:21 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-14 9:13 ` [Qemu-devel] [PATCH 11/11] vfio: Add guest side IOMMU support David Gibson
2013-05-14 9:48 ` Paolo Bonzini
2013-05-14 13:57 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-14 17:15 ` [Qemu-devel] " Alex Williamson
2013-05-15 1:33 ` [Qemu-devel] [Qemu-ppc] " David Gibson
2013-05-15 2:51 ` Alex Williamson
2013-05-15 3:32 ` David Gibson
2013-05-16 6:53 ` David Gibson
2013-05-14 9:39 ` [Qemu-devel] [0/11] RFC: VFIO and guest side IOMMUs, version 3 Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1368522837-20747-6-git-send-email-david@gibson.dropbear.id.au \
--to=david@gibson.dropbear.id.au \
--cc=aik@ozlabs.ru \
--cc=alex.williamson@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).