From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36809) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcELt-0006rD-KD for qemu-devel@nongnu.org; Tue, 14 May 2013 08:29:11 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcELr-0006FH-EP for qemu-devel@nongnu.org; Tue, 14 May 2013 08:29:09 -0400 Received: from mx1.redhat.com ([209.132.183.28]:32253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcELr-0006Ez-4Q for qemu-devel@nongnu.org; Tue, 14 May 2013 08:29:07 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4ECT5CU024636 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Tue, 14 May 2013 08:29:06 -0400 From: Gerd Hoffmann Date: Tue, 14 May 2013 14:29:04 +0200 Message-Id: <1368534544-11826-1-git-send-email-kraxel@redhat.com> Subject: [Qemu-devel] [RESEND PATCH for-1.5] acpi: add dummy write function for acpi timer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Gerd Hoffmann , "Michael S. Tsirkin" Otherwise the guest can crash qemu (NULL pointer dereference). https://bugzilla.redhat.com/show_bug.cgi?id=947691 Signed-off-by: Gerd Hoffmann --- hw/acpi/core.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/hw/acpi/core.c b/hw/acpi/core.c index 64b8718..42eeace 100644 --- a/hw/acpi/core.c +++ b/hw/acpi/core.c @@ -462,8 +462,15 @@ static uint64_t acpi_pm_tmr_read(void *opaque, hwaddr addr, unsigned width) return acpi_pm_tmr_get(opaque); } +static void acpi_pm_tmr_write(void *opaque, hwaddr addr, uint64_t val, + unsigned width) +{ + /* nothing */ +} + static const MemoryRegionOps acpi_pm_tmr_ops = { .read = acpi_pm_tmr_read, + .write = acpi_pm_tmr_write, .valid.min_access_size = 4, .valid.max_access_size = 4, .endianness = DEVICE_LITTLE_ENDIAN, -- 1.7.9.7