From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:48465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UcNCV-0007QZ-QR for qemu-devel@nongnu.org; Tue, 14 May 2013 17:56:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UcNCU-0003zg-RU for qemu-devel@nongnu.org; Tue, 14 May 2013 17:56:03 -0400 Sender: fluxion From: Michael Roth Date: Tue, 14 May 2013 16:53:12 -0500 Message-Id: <1368568392-2127-16-git-send-email-mdroth@linux.vnet.ibm.com> In-Reply-To: <1368568392-2127-1-git-send-email-mdroth@linux.vnet.ibm.com> References: <1368568392-2127-1-git-send-email-mdroth@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH 15/15] qga: unlink just created guest-file if fchmod() or fdopen() fails on it List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, qemu-stable@nongnu.org From: Laszlo Ersek We shouldn't allow guest filesystem pollution on error paths. Suggested-by: Eric Blake Signed-off-by: Laszlo Ersek Reviewed-by: Eric Blake Reviewed-by: Luiz Capitulino Signed-off-by: Michael Roth (cherry picked from commit 2b720018060179b394f8ce736983373ab80dd37c) Signed-off-by: Michael Roth --- qga/commands-posix.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/qga/commands-posix.c b/qga/commands-posix.c index 933c700..e439851 100644 --- a/qga/commands-posix.c +++ b/qga/commands-posix.c @@ -277,6 +277,9 @@ safe_open_or_create(const char *path, const char *mode, Error **err) } close(fd); + if (oflag & O_CREAT) { + unlink(path); + } } } -- 1.7.9.5