qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Michael Roth <mdroth@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH 03/15] rng random backend: check for -EAGAIN errors on read
Date: Tue, 14 May 2013 16:53:00 -0500	[thread overview]
Message-ID: <1368568392-2127-4-git-send-email-mdroth@linux.vnet.ibm.com> (raw)
In-Reply-To: <1368568392-2127-1-git-send-email-mdroth@linux.vnet.ibm.com>

From: Amit Shah <amit.shah@redhat.com>

Not handling EAGAIN triggers the assert

qemu/backends/rng-random.c:44:entropy_available: assertion failed: (len != -1)
Aborted (core dumped)

This happens when starting a guest with '-device virtio-rng-pci',
issuing a 'cat /dev/hwrng' in the guest, while also doing 'cat
/dev/random' on the host.

Reported-by: yunpingzheng <yunzheng@redhat.com>
Signed-off-by: Amit Shah <amit.shah@redhat.com>
Message-id: eacda84dfaf2d99cf6d250b678be4e4d6c2088fb.1366108096.git.amit.shah@redhat.com
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
(cherry picked from commit acbbc036619092fcd2c882222e1be168bd972b3e)

Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
---
 backends/rng-random.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/backends/rng-random.c b/backends/rng-random.c
index 0d11088..813388b 100644
--- a/backends/rng-random.c
+++ b/backends/rng-random.c
@@ -41,6 +41,9 @@ static void entropy_available(void *opaque)
     ssize_t len;
 
     len = read(s->fd, buffer, s->size);
+    if (len < 0 && errno == EAGAIN) {
+        return;
+    }
     g_assert(len != -1);
 
     s->receive_func(s->opaque, buffer, len);
-- 
1.7.9.5

  parent reply	other threads:[~2013-05-14 21:55 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-14 21:52 [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday Michael Roth
2013-05-14 21:52 ` [Qemu-devel] [PATCH 01/15] nbd: unlock mutex in nbd_co_send_request() error path Michael Roth
2013-05-14 21:52 ` [Qemu-devel] [PATCH 02/15] qdev: Fix QOM unrealize behavior Michael Roth
2013-05-14 21:53 ` Michael Roth [this message]
2013-05-14 21:53 ` [Qemu-devel] [PATCH 04/15] tap: properly initialize vhostfds Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 05/15] virtio-ccw: Check indicators location Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 06/15] configure: Pick up libseccomp include path Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 07/15] target-mips: Fix accumulator arguments to gen_helper_dmult(u) Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 08/15] tcg/optimize: fix setcond2 optimization Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 09/15] qga: set umask 0077 when daemonizing (CVE-2013-2007) Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 10/15] tcg: Document tcg_qemu_tb_exec() and provide constants for low bit uses Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 11/15] cpu-exec: wrap tcg_qemu_tb_exec() in a fn to restore the PC Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 12/15] Handle CPU interrupts by inline checking of a flag Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 13/15] translate-all.c: Remove cpu_unlink_tb() Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 14/15] qga: distinguish binary modes in "guest_file_open_modes" map Michael Roth
2013-05-14 21:53 ` [Qemu-devel] [PATCH 15/15] qga: unlink just created guest-file if fchmod() or fdopen() fails on it Michael Roth
2013-05-15  4:49 ` [Qemu-devel] Patch Round-up for stable 1.4.2, freeze on Monday Michael Tokarev
2013-05-15  4:51   ` Michael Tokarev
2013-05-15 14:09 ` Brad Smith
2013-05-15 16:25   ` mdroth
2013-05-15 21:48 ` Cole Robinson
2013-05-16 17:20   ` mdroth
2013-05-17 12:43 ` Luiz Capitulino
2013-05-17 15:46 ` Doug Goldstein
2013-05-17 19:08   ` mdroth
2013-05-17 20:43     ` [Qemu-devel] [Qemu-stable] " Josh Durgin
2013-05-17 21:01       ` mdroth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368568392-2127-4-git-send-email-mdroth@linux.vnet.ibm.com \
    --to=mdroth@linux.vnet.ibm.com \
    --cc=aliguori@us.ibm.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).