qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: David Gibson <david@gibson.dropbear.id.au>
To: aliguori@us.ibm.com
Cc: aik@ozlabs.ru, qemu-devel@nongnu.org, blauwirbel@gmail.com,
	qemu-ppc@nongnu.org, aurel@aurel32.net,
	David Gibson <david@gibson.dropbear.id.au>
Subject: [Qemu-devel] [PATCH] target-ppc: Change default machine for 64-bit
Date: Fri, 17 May 2013 14:25:11 +1000	[thread overview]
Message-ID: <1368764711-13763-1-git-send-email-david@gibson.dropbear.id.au> (raw)

Currently, for qemu-system-ppc64, the default machine type is 'mac99'.
Since the mac99 machine is not being actively maintained, and shows quite
a few signs of bitrot, this is not very sensible.  This patch changes the
default machine to 'pseries', which is actively maintained and works well
with most modern ppc64 Linux distributions as a guest.

Because the pseries machine type is optional (it is only built when libfdt
is available), this can result in a build with no default machine.  In that
case vl.c will print a "No machine found" message.  This seems reasonable,
given that as mentioned, mac99 is unlikely to be a good choice.

Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
 hw/ppc/mac_newworld.c |    3 ---
 hw/ppc/spapr.c        |    1 +
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/hw/ppc/mac_newworld.c b/hw/ppc/mac_newworld.c
index ce44e95..dafe7d2 100644
--- a/hw/ppc/mac_newworld.c
+++ b/hw/ppc/mac_newworld.c
@@ -458,9 +458,6 @@ static QEMUMachine core99_machine = {
     .desc = "Mac99 based PowerMAC",
     .init = ppc_core99_init,
     .max_cpus = MAX_CPUS,
-#ifdef TARGET_PPC64
-    .is_default = 1,
-#endif
     DEFAULT_MACHINE_OPTIONS,
 };
 
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index 74a9306..ced1b63 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -1348,6 +1348,7 @@ static void ppc_spapr_init(QEMUMachineInitArgs *args)
 static QEMUMachine spapr_machine = {
     .name = "pseries",
     .desc = "pSeries Logical Partition (PAPR compliant)",
+    .is_default = 1,
     .init = ppc_spapr_init,
     .reset = ppc_spapr_reset,
     .block_default_type = IF_SCSI,
-- 
1.7.10.4

             reply	other threads:[~2013-05-17  4:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-17  4:25 David Gibson [this message]
2013-05-17  4:36 ` [Qemu-devel] [Qemu-ppc] [PATCH] target-ppc: Change default machine for 64-bit Benjamin Herrenschmidt
2013-05-17  5:17   ` David Gibson
2013-05-17  7:17     ` Peter Maydell
2013-05-17  7:22     ` Alexander Graf
2013-05-17  7:42 ` [Qemu-devel] " Andreas Färber
2013-05-17  8:01   ` [Qemu-devel] [Qemu-ppc] " Benjamin Herrenschmidt
2013-06-13 13:49   ` Alexander Graf
2013-06-13 18:31     ` Anthony Liguori
2013-06-13 18:44       ` Scott Wood
2013-06-13 19:02         ` Anthony Liguori
2013-06-13 20:44           ` Peter Maydell
2013-06-14 16:15           ` Andreas Färber
2013-06-14 14:28     ` Andreas Färber
2013-06-14 21:58       ` Benjamin Herrenschmidt
2013-06-16 10:20       ` David Gibson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1368764711-13763-1-git-send-email-david@gibson.dropbear.id.au \
    --to=david@gibson.dropbear.id.au \
    --cc=aik@ozlabs.ru \
    --cc=aliguori@us.ibm.com \
    --cc=aurel@aurel32.net \
    --cc=blauwirbel@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).