From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51149) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdGOZ-0003aK-5M for qemu-devel@nongnu.org; Fri, 17 May 2013 04:52:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UdGOU-0002Cl-Tp for qemu-devel@nongnu.org; Fri, 17 May 2013 04:52:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:38287) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UdGOU-0002Ch-Lz for qemu-devel@nongnu.org; Fri, 17 May 2013 04:52:06 -0400 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4H8q4im032042 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Fri, 17 May 2013 04:52:04 -0400 From: Stefan Hajnoczi Date: Fri, 17 May 2013 10:52:00 +0200 Message-Id: <1368780720-14852-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH] tests: set MALLOC_PERTURB_ to expose memory bugs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Lucas Meneghel Rodrigues , Stefan Hajnoczi glibc wipes malloc(3) memory when the MALLOC_PERTURB_ environment variable is set. The value of the environment variable determines the bit pattern used to wipe memory. For more information, see http://udrepper.livejournal.com/11429.html. Set MALLOC_PERTURB_ for gtester and qemu-iotests. Note we always set the environment variable to 1 so the test is deterministic. Setting a random variable might expose more bugs but would be harder to reproduce. Both make check and qemu-iotests pass with MALLOC_PERTURB_ enabled. Signed-off-by: Stefan Hajnoczi --- Lucas noticed KVM autotest failures when enabling MALLOC_PERTURB_. By enabling it for in-tree test suites we can detect memory management errors earlier. tests/Makefile | 4 +++- tests/qemu-iotests/check | 2 +- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/Makefile b/tests/Makefile index a307d5a..25f6d28 100644 --- a/tests/Makefile +++ b/tests/Makefile @@ -171,6 +171,7 @@ GCOV_OPTIONS = -n $(if $(V),-f,) $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) $(call quiet-command,QTEST_QEMU_BINARY=$*-softmmu/qemu-system-$* \ + MALLOC_PERTURB_=1 \ gtester $(GTESTER_OPTIONS) -m=$(SPEED) $(check-qtest-$*-y),"GTESTER $@") $(if $(CONFIG_GCOV),@for f in $(gcov-files-$*-y); do \ echo Gcov report for $$f:;\ @@ -180,7 +181,8 @@ $(patsubst %, check-qtest-%, $(QTEST_TARGETS)): check-qtest-%: $(check-qtest-y) .PHONY: $(patsubst %, check-%, $(check-unit-y)) $(patsubst %, check-%, $(check-unit-y)): check-%: % $(if $(CONFIG_GCOV),@rm -f *.gcda */*.gcda */*/*.gcda */*/*/*.gcda,) - $(call quiet-command,gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER $*") + $(call quiet-command,MALLOC_PERTURB_=1 \ + gtester $(GTESTER_OPTIONS) -m=$(SPEED) $*,"GTESTER $*") $(if $(CONFIG_GCOV),@for f in $(gcov-files-$(subst tests/,,$*)-y); do \ echo Gcov report for $$f:;\ $(GCOV) $(GCOV_OPTIONS) $$f -o `dirname $$f`; \ diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check index 432732c..1527cda 100755 --- a/tests/qemu-iotests/check +++ b/tests/qemu-iotests/check @@ -214,7 +214,7 @@ do start=`_wallclock` $timestamp && echo -n " ["`date "+%T"`"]" [ ! -x $seq ] && chmod u+x $seq # ensure we can run it - ./$seq >$tmp.out 2>&1 + MALLOC_PERTURB_=1 ./$seq >$tmp.out 2>&1 sts=$? $timestamp && _timestamp stop=`_wallclock` -- 1.8.1.4