qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v4 02/10] curl: change magic number to sizeof
Date: Wed, 22 May 2013 11:16:42 +0800	[thread overview]
Message-ID: <1369192610-25003-3-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1369192610-25003-1-git-send-email-famz@redhat.com>

String field length is duplicated in two places. Make it a sizeof.

Signed-off-by: Fam Zheng <famz@redhat.com>
---
 block/curl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/block/curl.c b/block/curl.c
index 2e42cd1..d0bc66f 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -569,7 +569,7 @@ static void curl_readv_bh_cb(void *p)
     state->orig_buf = g_malloc(state->buf_len);
     state->acb[0] = acb;
 
-    snprintf(state->range, 127, "%zd-%zd", start, end);
+    snprintf(state->range, sizeof(state->range) - 1, "%zd-%zd", start, end);
     DPRINTF("CURL (AIO): Reading %d at %zd (%s)\n",
             (acb->nb_sectors * SECTOR_SIZE), start, state->range);
     curl_easy_setopt(state->curl, CURLOPT_RANGE, state->range);
-- 
1.8.2.3

  parent reply	other threads:[~2013-05-22  3:17 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-22  3:16 [Qemu-devel] [PATCH v4 00/10] curl: fix curl read Fam Zheng
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 01/10] curl: introduce CURLSockInfo to BDRVCURLState Fam Zheng
2013-05-22  3:16 ` Fam Zheng [this message]
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 03/10] curl: change curl_multi_do to curl_fd_handler Fam Zheng
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 04/10] curl: fix curl_open Fam Zheng
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 05/10] curl: add timer to BDRVCURLState Fam Zheng
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 06/10] curl: introduce CURLDataCache Fam Zheng
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 07/10] curl: make use of CURLDataCache Fam Zheng
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 08/10] curl: use list to store CURLState Fam Zheng
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 09/10] curl: add cache quota Fam Zheng
2013-05-22  3:16 ` [Qemu-devel] [PATCH v4 10/10] curl: introduce ssl_no_cert runtime option Fam Zheng
2013-05-22  9:32 ` [Qemu-devel] [PATCH v4 00/10] curl: fix curl read Fam Zheng
2013-05-22  9:44 ` Richard W.M. Jones
2013-05-22 11:04   ` Paolo Bonzini
2013-05-22 11:12     ` Richard W.M. Jones
2013-05-22 14:39       ` Stefan Hajnoczi
2013-05-23  0:38         ` Fam Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369192610-25003-3-git-send-email-famz@redhat.com \
    --to=famz@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).