From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Jens Freimann" <jfrei@linux.vnet.ibm.com>,
"Vincent Rabin" <rabin@rab.in>,
"Qiao Nuohan" <qiaonuohan@cn.fujitsu.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH qom-cpu 2/4] memory_mapping: Change cpu_get_memory_mapping() argument to CPUState
Date: Wed, 22 May 2013 15:09:07 +0200 [thread overview]
Message-ID: <1369228150-5428-3-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1369228150-5428-1-git-send-email-afaerber@suse.de>
Eliminates an occurrence of CPUArchState from sysemu/memory_mapping.h.
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
include/sysemu/memory_mapping.h | 2 +-
memory_mapping.c | 2 +-
target-i386/arch_memory_mapping.c | 5 ++++-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/include/sysemu/memory_mapping.h b/include/sysemu/memory_mapping.h
index 0a418a7..2e2893a 100644
--- a/include/sysemu/memory_mapping.h
+++ b/include/sysemu/memory_mapping.h
@@ -30,7 +30,7 @@ typedef struct MemoryMappingList {
QTAILQ_HEAD(, MemoryMapping) head;
} MemoryMappingList;
-int cpu_get_memory_mapping(MemoryMappingList *list, CPUArchState *env);
+int cpu_get_memory_mapping(MemoryMappingList *list, CPUState *cpu);
bool cpu_paging_enabled(CPUArchState *env);
/*
diff --git a/memory_mapping.c b/memory_mapping.c
index 4867ae4..fe8e0ff 100644
--- a/memory_mapping.c
+++ b/memory_mapping.c
@@ -138,7 +138,7 @@ int qemu_get_guest_memory_mapping(MemoryMappingList *list)
first_paging_enabled_cpu = find_paging_enabled_cpu(first_cpu);
if (first_paging_enabled_cpu) {
for (env = first_paging_enabled_cpu; env != NULL; env = env->next_cpu) {
- ret = cpu_get_memory_mapping(list, env);
+ ret = cpu_get_memory_mapping(list, ENV_GET_CPU(env));
if (ret < 0) {
return -1;
}
diff --git a/target-i386/arch_memory_mapping.c b/target-i386/arch_memory_mapping.c
index a2eb7e7..187c3df 100644
--- a/target-i386/arch_memory_mapping.c
+++ b/target-i386/arch_memory_mapping.c
@@ -237,8 +237,11 @@ static void walk_pml4e(MemoryMappingList *list,
}
#endif
-int cpu_get_memory_mapping(MemoryMappingList *list, CPUArchState *env)
+int cpu_get_memory_mapping(MemoryMappingList *list, CPUState *cs)
{
+ X86CPU *cpu = X86_CPU(cs);
+ CPUX86State *env = &cpu->env;
+
if (!cpu_paging_enabled(env)) {
/* paging is disabled */
return 0;
--
1.8.1.4
next prev parent reply other threads:[~2013-05-22 13:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 13:09 [Qemu-devel] [PATCH qom-cpu 0/4] memory_mapping: Clean up stubs Andreas Färber
2013-05-22 13:09 ` [Qemu-devel] [PATCH qom-cpu 1/4] memory_mapping: Use hwaddr type for MemoryMapping virt_addr field Andreas Färber
2013-05-22 13:09 ` Andreas Färber [this message]
2013-05-22 13:09 ` [Qemu-devel] [PATCH qom-cpu 3/4] memory_mapping: Change cpu_paging_enabled() argument to CPUState Andreas Färber
2013-05-22 13:09 ` [Qemu-devel] [PATCH qom-cpu 4/4] memory_mapping: Move stubs to libqemustub.a Andreas Färber
2013-05-23 10:08 ` Paolo Bonzini
2013-05-28 9:39 ` Andreas Färber
2013-05-28 9:53 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369228150-5428-3-git-send-email-afaerber@suse.de \
--to=afaerber@suse.de \
--cc=jfrei@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qiaonuohan@cn.fujitsu.com \
--cc=rabin@rab.in \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).