* [Qemu-devel] [PATCH] configure: remove confusing file manipulation
@ 2013-05-22 13:21 Ed Maste
2013-05-25 9:31 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 1 reply; 2+ messages in thread
From: Ed Maste @ 2013-05-22 13:21 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Ed Maste
The configure script had some code to manipulate config-host.ld~ (i.e.,
a common backup filename), comparing it with the newly-generated file.
I believe the sense of the comparison was backwards.
Since it seemed to serve little purpose anyway, remove it to avoid any
confusion.
Signed-off-by: Ed Maste <emaste@freebsd.org>
---
configure | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/configure b/configure
index 5ae7e4a..cfdb564 100755
--- a/configure
+++ b/configure
@@ -4104,17 +4104,8 @@ if test "$gcov" = "yes" ; then
fi
# generate list of library paths for linker script
-
$ld --verbose -v 2> /dev/null | grep SEARCH_DIR > ${config_host_ld}
-if test -f ${config_host_ld}~ ; then
- if cmp -s $config_host_ld ${config_host_ld}~ ; then
- mv ${config_host_ld}~ $config_host_ld
- else
- rm ${config_host_ld}~
- fi
-fi
-
# use included Linux headers
if test "$linux" = "yes" ; then
mkdir -p linux-headers
--
1.7.11.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [Qemu-trivial] [PATCH] configure: remove confusing file manipulation
2013-05-22 13:21 [Qemu-devel] [PATCH] configure: remove confusing file manipulation Ed Maste
@ 2013-05-25 9:31 ` Michael Tokarev
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2013-05-25 9:31 UTC (permalink / raw)
To: Ed Maste; +Cc: qemu-trivial, qemu-devel
22.05.2013 17:21, Ed Maste wrote:
> The configure script had some code to manipulate config-host.ld~ (i.e.,
> a common backup filename), comparing it with the newly-generated file.
> I believe the sense of the comparison was backwards.
>
> Since it seemed to serve little purpose anyway, remove it to avoid any
> confusion.
Thanks, applied to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-25 9:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-22 13:21 [Qemu-devel] [PATCH] configure: remove confusing file manipulation Ed Maste
2013-05-25 9:31 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).