From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43465) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfRDf-0000ZD-K4 for qemu-devel@nongnu.org; Thu, 23 May 2013 04:49:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfRDd-0002WC-Ij for qemu-devel@nongnu.org; Thu, 23 May 2013 04:49:55 -0400 Received: from e23smtp09.au.ibm.com ([202.81.31.142]:35064) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfRDc-0002TM-Tk for qemu-devel@nongnu.org; Thu, 23 May 2013 04:49:53 -0400 Received: from /spool/local by e23smtp09.au.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 24 May 2013 05:46:57 +1000 Received: from d23relay04.au.ibm.com (d23relay04.au.ibm.com [9.190.234.120]) by d23dlp03.au.ibm.com (Postfix) with ESMTP id CF9DF3578050 for ; Thu, 23 May 2013 18:49:33 +1000 (EST) Received: from d23av01.au.ibm.com (d23av01.au.ibm.com [9.190.234.96]) by d23relay04.au.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id r4N8ZNRN18677824 for ; Thu, 23 May 2013 18:35:24 +1000 Received: from d23av01.au.ibm.com (loopback [127.0.0.1]) by d23av01.au.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id r4N8nWgh010527 for ; Thu, 23 May 2013 18:49:32 +1000 From: Wenchao Xia Date: Thu, 23 May 2013 16:47:11 +0800 Message-Id: <1369298836-17416-1-git-send-email-xiawenc@linux.vnet.ibm.com> Subject: [Qemu-devel] [PATCH V2 0/5] qapi and snapshot code clean up in block layer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, phrdina@redhat.com, stefanha@gmail.com, armbru@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com, Wenchao Xia These patches are the common part of my hmp/qmp block query series and Pavel's qmp snapshot command converion series. It mainly does following things: 1 move snapshot related code to block/snapshot.c, qmp and info dumping code to block/qapi.c. 2 better info dumping function to get rid of buffer, avoid string truncation. Stefan Hajnoczi (1): 1 block: drop bs_snapshots global variable v2: Squash code moving patches since they are reviewed in v1. Drop bdrv_snapshot_find() function change patch, since it related to snapshot logic which should be changed together with Pavel's serial. Use a parameter in message_printf() to tell where to print, instead of use global variable "cur_mon" inside. Wenchao Xia (4): 2 block: move snapshot code in block.c to block/snapshot.c 3 block: move qmp and info dump related code to block/qapi.c 4 util: add new function message_printf() 5 block: dump to specified output for bdrv_snapshot_dump() and bdrv_image_info_dump() block.c | 318 ------------------------------------- block/Makefile.objs | 1 + block/qapi.c | 365 +++++++++++++++++++++++++++++++++++++++++++ block/snapshot.c | 162 +++++++++++++++++++ include/block/block.h | 29 +---- include/block/block_int.h | 1 + include/block/qapi.h | 42 +++++ include/block/snapshot.h | 54 +++++++ include/qemu/error-report.h | 13 ++ qemu-img.c | 169 ++------------------- savevm.c | 44 +++--- util/qemu-error.c | 28 +++- 12 files changed, 697 insertions(+), 529 deletions(-) create mode 100644 block/qapi.c create mode 100644 block/snapshot.c create mode 100644 include/block/qapi.h create mode 100644 include/block/snapshot.h