From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: aliguori@us.ibm.com
Subject: [Qemu-devel] [PULL 02/12] qapi: qapi-visit.py, fix list handling for union types
Date: Thu, 23 May 2013 14:20:22 -0400 [thread overview]
Message-ID: <1369333232-24145-3-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1369333232-24145-1-git-send-email-lcapitulino@redhat.com>
From: Michael Roth <mdroth@linux.vnet.ibm.com>
Currently we assume non-list types when generating visitor routines for
union types. This is broken, since values like ['Type'] need to mapped
to 'TypeList'.
We already have a type_name() function to handle this that we use for
generating struct visitors, so use that here as well.
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Amos Kong <akong@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
scripts/qapi-visit.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py
index a276540..4c4de4b 100644
--- a/scripts/qapi-visit.py
+++ b/scripts/qapi-visit.py
@@ -174,7 +174,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error **
''',
abbrev = de_camel_case(name).upper(),
enum = c_fun(de_camel_case(key),False).upper(),
- c_type=members[key],
+ c_type=type_name(members[key]),
c_name=c_fun(key))
ret += mcgen('''
--
1.8.1.4
next prev parent reply other threads:[~2013-05-23 18:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-23 18:20 [Qemu-devel] [PULL 00/12] QMP queue Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 01/12] qapi: qapi-types.py, native list support Luiz Capitulino
2013-05-23 18:20 ` Luiz Capitulino [this message]
2013-05-23 18:20 ` [Qemu-devel] [PULL 03/12] qapi: qapi-visit.py, " Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 04/12] qapi: enable generation of native list code Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 05/12] json-parser: fix handling of large whole number values Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 06/12] qapi: add QMP input test for large integers Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 07/12] qapi: fix visitor serialization tests for numbers/doubles Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 08/12] qapi: add native list coverage for visitor serialization tests Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 09/12] qapi: add native list coverage for QMP output visitor tests Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 10/12] qapi: add native list coverage for QMP input " Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 11/12] ui/input.c: replace magic numbers with macros Luiz Capitulino
2013-05-23 18:20 ` [Qemu-devel] [PULL 12/12] monitor: allow to disable the default monitor Luiz Capitulino
2013-06-17 21:18 ` [Qemu-devel] [PULL 00/12] QMP queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369333232-24145-3-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).