From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49604) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ufa82-00052A-2w for qemu-devel@nongnu.org; Thu, 23 May 2013 14:20:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ufa7x-0003SZ-8x for qemu-devel@nongnu.org; Thu, 23 May 2013 14:20:41 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33190) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ufa7x-0003SK-19 for qemu-devel@nongnu.org; Thu, 23 May 2013 14:20:37 -0400 From: Luiz Capitulino Date: Thu, 23 May 2013 14:20:22 -0400 Message-Id: <1369333232-24145-3-git-send-email-lcapitulino@redhat.com> In-Reply-To: <1369333232-24145-1-git-send-email-lcapitulino@redhat.com> References: <1369333232-24145-1-git-send-email-lcapitulino@redhat.com> Subject: [Qemu-devel] [PULL 02/12] qapi: qapi-visit.py, fix list handling for union types List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com From: Michael Roth Currently we assume non-list types when generating visitor routines for union types. This is broken, since values like ['Type'] need to mapped to 'TypeList'. We already have a type_name() function to handle this that we use for generating struct visitors, so use that here as well. Signed-off-by: Michael Roth Reviewed-by: Laszlo Ersek Reviewed-by: Amos Kong Signed-off-by: Luiz Capitulino --- scripts/qapi-visit.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qapi-visit.py b/scripts/qapi-visit.py index a276540..4c4de4b 100644 --- a/scripts/qapi-visit.py +++ b/scripts/qapi-visit.py @@ -174,7 +174,7 @@ void visit_type_%(name)s(Visitor *m, %(name)s ** obj, const char *name, Error ** ''', abbrev = de_camel_case(name).upper(), enum = c_fun(de_camel_case(key),False).upper(), - c_type=members[key], + c_type=type_name(members[key]), c_name=c_fun(key)) ret += mcgen(''' -- 1.8.1.4