From: Fam Zheng <famz@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, jcody@redhat.com, Fam Zheng <famz@redhat.com>,
rjones@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v6 02/12] curl: change magic number to sizeof
Date: Fri, 24 May 2013 13:36:57 +0800 [thread overview]
Message-ID: <1369373827-9152-3-git-send-email-famz@redhat.com> (raw)
In-Reply-To: <1369373827-9152-1-git-send-email-famz@redhat.com>
String field length is duplicated in two places. Make it a sizeof.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
block/curl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/block/curl.c b/block/curl.c
index a829fe7..a11002b 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -569,7 +569,7 @@ static void curl_readv_bh_cb(void *p)
state->orig_buf = g_malloc(state->buf_len);
state->acb[0] = acb;
- snprintf(state->range, 127, "%zd-%zd", start, end);
+ snprintf(state->range, sizeof(state->range) - 1, "%zd-%zd", start, end);
DPRINTF("CURL (AIO): Reading %d at %zd (%s)\n",
(acb->nb_sectors * SECTOR_SIZE), start, state->range);
curl_easy_setopt(state->curl, CURLOPT_RANGE, state->range);
--
1.8.2.3
next prev parent reply other threads:[~2013-05-24 5:37 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 5:36 [Qemu-devel] [PATCH v6 00/12] curl: fix curl read Fam Zheng
2013-05-24 5:36 ` [Qemu-devel] [PATCH v6 01/12] curl: introduce CURLSockInfo to BDRVCURLState Fam Zheng
2013-05-24 5:36 ` Fam Zheng [this message]
2013-05-24 5:36 ` [Qemu-devel] [PATCH v6 03/12] curl: change curl_multi_do to curl_fd_handler Fam Zheng
2013-05-24 5:36 ` [Qemu-devel] [PATCH v6 04/12] curl: fix curl_open Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 05/12] curl: add timer to BDRVCURLState Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 06/12] curl: introduce CURLDataCache Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 07/12] curl: make use of CURLDataCache Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 08/12] curl: use list to store CURLState Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 09/12] curl: add cache quota Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 10/12] curl: introduce ssl_no_cert runtime option Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 11/12] block/curl.c: Refuse to open the handle for writes Fam Zheng
2013-05-24 5:37 ` [Qemu-devel] [PATCH v6 12/12] curl: set s->url to NULL after free Fam Zheng
2013-05-24 8:07 ` [Qemu-devel] [PATCH v6 00/12] curl: fix curl read Richard W.M. Jones
2013-05-27 2:25 ` Fam Zheng
2013-05-27 11:57 ` Richard W.M. Jones
2013-05-28 7:30 ` Fam Zheng
2013-05-28 7:47 ` Richard W.M. Jones
2013-05-28 8:46 ` Richard W.M. Jones
2013-05-28 8:52 ` Fam Zheng
2013-05-28 8:53 ` Richard W.M. Jones
2013-05-28 10:35 ` Richard W.M. Jones
2013-05-28 11:01 ` Richard W.M. Jones
2013-05-28 11:14 ` Fam Zheng
2013-05-28 11:25 ` Richard W.M. Jones
2013-05-28 11:32 ` Richard W.M. Jones
2013-05-29 1:07 ` Fam Zheng
2013-05-29 9:25 ` Richard W.M. Jones
2013-05-28 11:34 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369373827-9152-3-git-send-email-famz@redhat.com \
--to=famz@redhat.com \
--cc=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rjones@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).