From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Cc: Avi Kivity <avi.kivity@gmail.com>
Subject: [Qemu-devel] [PATCH 11/15] memory: fix address space initialization/destruction
Date: Fri, 24 May 2013 19:03:03 +0200 [thread overview]
Message-ID: <1369414987-8839-12-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1369414987-8839-1-git-send-email-pbonzini@redhat.com>
From: Avi Kivity <avi.kivity@gmail.com>
A couple of fields were left uninitialized. This was not observed earlier
because all address spaces were statically allocated. Also free allocation
for those fields.
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Avi Kivity <avi.kivity@gmail.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
memory.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/memory.c b/memory.c
index 11bbeb7..9478f98 100644
--- a/memory.c
+++ b/memory.c
@@ -1572,6 +1572,8 @@ void address_space_init(AddressSpace *as, MemoryRegion *root)
as->root = root;
as->current_map = g_new(FlatView, 1);
flatview_init(as->current_map);
+ as->ioeventfd_nb = 0;
+ as->ioeventfds = NULL;
QTAILQ_INSERT_TAIL(&address_spaces, as, address_spaces_link);
as->name = NULL;
memory_region_transaction_commit();
@@ -1588,6 +1590,7 @@ void address_space_destroy(AddressSpace *as)
address_space_destroy_dispatch(as);
flatview_destroy(as->current_map);
g_free(as->current_map);
+ g_free(as->ioeventfds);
}
uint64_t io_mem_read(MemoryRegion *mr, hwaddr addr, unsigned size)
--
1.8.1.4
next prev parent reply other threads:[~2013-05-24 17:03 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-24 17:02 [Qemu-devel] [PULL 00/15] IOMMU patches for 1.6, part 1 Paolo Bonzini
2013-05-24 17:02 ` [Qemu-devel] [PATCH 01/15] exec: remove obsolete comment Paolo Bonzini
2013-05-24 17:02 ` [Qemu-devel] [PATCH 02/15] exec: eliminate qemu_put_ram_ptr Paolo Bonzini
2013-05-24 17:02 ` [Qemu-devel] [PATCH 03/15] exec: make qemu_get_ram_ptr private Paolo Bonzini
2013-05-24 17:02 ` [Qemu-devel] [PATCH 04/15] exec: eliminate stq_phys_notdirty Paolo Bonzini
2013-05-24 17:02 ` [Qemu-devel] [PATCH 05/15] memory: assert that PhysPageEntry's ptr does not overflow Paolo Bonzini
2013-05-24 17:02 ` [Qemu-devel] [PATCH 06/15] memory: allow memory_region_find() to run on non-root memory regions Paolo Bonzini
2013-05-24 17:02 ` [Qemu-devel] [PATCH 07/15] memory: Replace open-coded memory_region_is_romd Paolo Bonzini
2013-05-24 17:03 ` [Qemu-devel] [PATCH 08/15] memory: Rename readable flag to romd_mode Paolo Bonzini
2013-05-24 17:03 ` [Qemu-devel] [PATCH 09/15] memory: do not duplicate memory_region_destructor_none Paolo Bonzini
2013-05-24 17:03 ` [Qemu-devel] [PATCH 10/15] memory: make memory_global_sync_dirty_bitmap take an AddressSpace Paolo Bonzini
2013-05-24 17:03 ` Paolo Bonzini [this message]
2013-05-24 17:03 ` [Qemu-devel] [PATCH 12/15] s390x: reduce TARGET_PHYS_ADDR_SPACE_BITS to 62 Paolo Bonzini
2013-05-26 14:14 ` Andreas Färber
2013-05-26 19:07 ` Paolo Bonzini
2013-05-26 21:08 ` Christian Borntraeger
2013-05-27 7:28 ` Paolo Bonzini
2013-05-27 12:52 ` Andreas Färber
2013-05-27 13:13 ` Paolo Bonzini
2013-05-24 17:03 ` [Qemu-devel] [PATCH 13/15] memory: limit sections in the radix tree to the actual address space size Paolo Bonzini
2013-05-24 17:03 ` [Qemu-devel] [PATCH 14/15] memory: populate FlatView for new address spaces Paolo Bonzini
2013-05-24 17:03 ` [Qemu-devel] [PATCH 15/15] memory: clean up phys_page_find Paolo Bonzini
2013-05-27 8:13 ` [Qemu-devel] [PULL 00/15] IOMMU patches for 1.6, part 1 Paolo Bonzini
2013-06-17 21:18 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369414987-8839-12-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=avi.kivity@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).