From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44707) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfvOj-0001bZ-D7 for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UfvOe-0000xq-L6 for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:21 -0400 Received: from mail-ee0-f53.google.com ([74.125.83.53]:34367) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UfvOe-0000xh-EG for qemu-devel@nongnu.org; Fri, 24 May 2013 13:03:16 -0400 Received: by mail-ee0-f53.google.com with SMTP id c1so2726593eek.12 for ; Fri, 24 May 2013 10:03:15 -0700 (PDT) Received: from playground.lan (net-37-117-138-128.cust.dsl.vodafone.it. [37.117.138.128]) by mx.google.com with ESMTPSA id z52sm24872219eea.1.2013.05.24.10.03.13 for (version=TLSv1.2 cipher=RC4-SHA bits=128/128); Fri, 24 May 2013 10:03:14 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Fri, 24 May 2013 19:02:53 +0200 Message-Id: <1369414987-8839-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1369414987-8839-1-git-send-email-pbonzini@redhat.com> References: <1369414987-8839-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 01/15] exec: remove obsolete comment List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org See how we call memory_region_section_addr two lines below to convert a physical address to a base address in the region. Reviewed-by: Peter Maydell Signed-off-by: Paolo Bonzini --- exec.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/exec.c b/exec.c index aec65c5..197625c 100644 --- a/exec.c +++ b/exec.c @@ -639,12 +639,6 @@ hwaddr memory_region_section_get_iotlb(CPUArchState *env, iotlb |= phys_section_rom; } } else { - /* IO handlers are currently passed a physical address. - It would be nice to pass an offset from the base address - of that region. This would avoid having to special case RAM, - and avoid full address decoding in every device. - We can't use the high bits of pd for this because - IO_MEM_ROMD uses these as a ram address. */ iotlb = section - phys_sections; iotlb += memory_region_section_addr(section, paddr); } -- 1.8.1.4