qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, phrdina@redhat.com, stefanha@gmail.com,
	armbru@redhat.com, lcapitulino@redhat.com, pbonzini@redhat.com,
	Wenchao Xia <xiawenc@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer
Date: Sat, 25 May 2013 11:09:41 +0800	[thread overview]
Message-ID: <1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)

These patches are the common part of my hmp/qmp block query series and Pavel's
qmp snapshot command converion series. It mainly does following things:
1 move snapshot related code to block/snapshot.c, qmp and info dumping code to
block/qapi.c.
2 better info dumping function to get rid of buffer, avoid string truncation.

v2:
  Squash code moving patches since they are reviewed in v1.
  Drop bdrv_snapshot_find() function change patch, since it related to snapshot
logic which should be changed together with Pavel's serial.
  Use a parameter in message_printf() to tell where to print, instead of use
global variable "cur_mon" inside.

v3:
  Address Stefan's comments:
  2/4: do not move bdrv_is_snapshot().
  4/4: reuse fprintf_function function pointer instead of a new function.

Stefan Hajnoczi (1):
  1 block: drop bs_snapshots global variable

Wenchao Xia (3):
  2 block: move snapshot code in block.c to block/snapshot.c
  3 block: move qmp and info dump related code to block/qapi.c
  4 block: dump snapshot and image info to specified output

 block.c                   |  313 --------------------------------------
 block/Makefile.objs       |    1 +
 block/qapi.c              |  366 +++++++++++++++++++++++++++++++++++++++++++++
 block/snapshot.c          |  157 +++++++++++++++++++
 include/block/block.h     |   28 +----
 include/block/block_int.h |    1 +
 include/block/qapi.h      |   43 ++++++
 include/block/snapshot.h  |   53 +++++++
 qemu-img.c                |  163 +-------------------
 savevm.c                  |   40 ++---
 10 files changed, 646 insertions(+), 519 deletions(-)
 create mode 100644 block/qapi.c
 create mode 100644 block/snapshot.c
 create mode 100644 include/block/qapi.h
 create mode 100644 include/block/snapshot.h

             reply	other threads:[~2013-05-25  3:12 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-25  3:09 Wenchao Xia [this message]
2013-05-25  3:09 ` [Qemu-devel] [PATCH V3 1/4] block: drop bs_snapshots global variable Wenchao Xia
2013-05-27 15:18   ` Kevin Wolf
2013-05-28  2:20     ` Wenchao Xia
2013-05-27 15:25   ` Kevin Wolf
2013-05-28  2:24     ` Wenchao Xia
2013-05-28  7:46     ` Stefan Hajnoczi
2013-05-29  7:54       ` Wenchao Xia
2013-05-29  9:09         ` Stefan Hajnoczi
2013-05-29  9:45           ` Wenchao Xia
2013-05-25  3:09 ` [Qemu-devel] [PATCH V3 2/4] block: move snapshot code in block.c to block/snapshot.c Wenchao Xia
2013-05-25 12:17   ` Eric Blake
2013-05-25  3:09 ` [Qemu-devel] [PATCH V3 3/4] block: move qmp and info dump related code to block/qapi.c Wenchao Xia
2013-05-25  3:09 ` [Qemu-devel] [PATCH V3 4/4] block: dump snapshot and image info to specified output Wenchao Xia
2013-05-25 12:15   ` Eric Blake
2013-05-27 15:02   ` Luiz Capitulino
2013-05-27 15:40     ` Kevin Wolf
2013-05-27 15:55       ` Luiz Capitulino
2013-05-28  2:09       ` Wenchao Xia
2013-05-27 15:41 ` [Qemu-devel] [PATCH V3 0/4] qapi and snapshot code clean up in block layer Kevin Wolf
2013-05-30  2:41   ` Wenchao Xia
2013-05-31 13:04     ` Wenchao Xia
2013-05-31 13:19       ` Luiz Capitulino
2013-06-03  2:22         ` Wenchao Xia
2013-06-04 12:46 ` Kevin Wolf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369451385-23452-1-git-send-email-xiawenc@linux.vnet.ibm.com \
    --to=xiawenc@linux.vnet.ibm.com \
    --cc=armbru@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=lcapitulino@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=phrdina@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).