From: qiaonuohan@cn.fujitsu.com
To: eblake@redhat.com, lcapitulino@redhat.com, afaerber@suse.de
Cc: zhangxh@cn.fujitsu.com, kumagai-atsushi@mxc.nes.nec.co.jp,
Qiao Nuohan <qiaonuohan@cn.fujitsu.com>,
anderson@redhat.com, qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH v4 7/9] dump: Add API to free memory used by creating header, bitmap and page
Date: Tue, 28 May 2013 10:50:35 +0800 [thread overview]
Message-ID: <1369709437-24969-8-git-send-email-qiaonuohan@cn.fujitsu.com> (raw)
In-Reply-To: <1369709437-24969-1-git-send-email-qiaonuohan@cn.fujitsu.com>
From: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
When calling create_header, create_dump_bitmap and create_pages, some memory
spaces are allocated. The following patch will use this function to free these
memory.
Signed-off-by: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
Reviewed-by: Zhang Xiaohe <zhangxh@cn.fujitsu.com>
---
dump.c | 19 +++++++++++++++++++
1 files changed, 19 insertions(+), 0 deletions(-)
diff --git a/dump.c b/dump.c
index 405eeb1..91a2384 100644
--- a/dump.c
+++ b/dump.c
@@ -1261,6 +1261,25 @@ cleanup:
return -1;
}
+static void clean_state(DumpState *s)
+{
+ if (s->dh) {
+ g_free(s->dh);
+ }
+
+ if (s->kh) {
+ g_free(s->kh);
+ }
+
+ free_dump_bitmap(s->dump_bitmap1);
+
+ free_dump_bitmap(s->dump_bitmap2);
+
+ free_cache_data(s->page_desc);
+
+ free_cache_data(s->page_data);
+}
+
void qmp_dump_guest_memory(bool paging, const char *file, bool has_begin,
int64_t begin, bool has_length, int64_t length,
Error **errp)
--
1.7.1
next prev parent reply other threads:[~2013-05-28 2:51 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 2:50 [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format qiaonuohan
2013-05-28 2:50 ` [Qemu-devel] [PATCH v4 1/9] dump: Add API to manipulate dump_bitmap qiaonuohan
2013-06-19 11:42 ` Andreas Färber
2013-06-19 12:00 ` Andreas Färber
2013-05-28 2:50 ` [Qemu-devel] [PATCH v4 2/9] dump: Add API to manipulate cache_data qiaonuohan
2013-06-19 12:29 ` Andreas Färber
2013-06-21 11:00 ` Eric Blake
2013-05-28 2:50 ` [Qemu-devel] [PATCH v4 3/9] dump: Move struct definition into dump_memroy.h qiaonuohan
2013-06-19 13:08 ` Andreas Färber
2013-05-28 2:50 ` [Qemu-devel] [PATCH v4 4/9] dump: Add API to create header of vmcore qiaonuohan
2013-06-19 13:23 ` Andreas Färber
2013-05-28 2:50 ` [Qemu-devel] [PATCH v4 5/9] dump: Add API to create data of dump bitmap qiaonuohan
2013-05-28 2:50 ` [Qemu-devel] [PATCH v4 6/9] dump: Add API to create page qiaonuohan
2013-05-28 2:50 ` qiaonuohan [this message]
2013-05-28 2:50 ` [Qemu-devel] [PATCH v4 8/9] dump: Add API to write header, bitmap and page into vmcore qiaonuohan
2013-05-28 2:50 ` [Qemu-devel] [PATCH v4 9/9] dump: Make kdump-compressed format available for 'dump-guest-memory' qiaonuohan
2013-06-19 13:10 ` Stefan Hajnoczi
2013-06-05 1:29 ` [Qemu-devel] [PATCH v4 0/9] Make 'dump-guest-memory' dump in kdump-compressed format Qiao Nuohan
2013-06-05 2:12 ` Luiz Capitulino
2013-06-05 2:15 ` Luiz Capitulino
2013-06-05 11:44 ` Amos Kong
2013-06-10 2:15 ` Qiao Nuohan
2013-06-10 12:54 ` Luiz Capitulino
2013-06-11 1:48 ` Qiao Nuohan
2013-06-13 18:12 ` Luiz Capitulino
2013-06-19 10:07 ` Qiao Nuohan
2013-06-19 13:49 ` Stefan Hajnoczi
2013-06-20 2:18 ` Qiao Nuohan
2013-06-20 8:57 ` Stefan Hajnoczi
2013-06-27 7:11 ` Qiao Nuohan
2013-06-27 8:54 ` Stefan Hajnoczi
2013-06-28 2:57 ` Qiao Nuohan
2013-07-01 11:45 ` Stefan Hajnoczi
2013-07-03 7:39 ` Qiao Nuohan
2013-07-04 8:26 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369709437-24969-8-git-send-email-qiaonuohan@cn.fujitsu.com \
--to=qiaonuohan@cn.fujitsu.com \
--cc=afaerber@suse.de \
--cc=anderson@redhat.com \
--cc=eblake@redhat.com \
--cc=kumagai-atsushi@mxc.nes.nec.co.jp \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=zhangxh@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).