From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Anthony Liguori <aliguori@us.ibm.com>,
seabios@seabios.org, qemu-stable@nongnu.org,
Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 2/2] chardev: fix "info chardev" output
Date: Tue, 28 May 2013 12:27:59 +0200 [thread overview]
Message-ID: <1369736879-16503-3-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1369736879-16503-1-git-send-email-kraxel@redhat.com>
Fill unset CharDriverState->filename with the backend name, so
'info chardev' will return at least the chardev type. Don't
touch it in case the chardev init function filled it already,
like the socket+pty chardevs do for example.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
qemu-char.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/qemu-char.c b/qemu-char.c
index f825294..d04b429 100644
--- a/qemu-char.c
+++ b/qemu-char.c
@@ -3801,6 +3801,9 @@ ChardevReturn *qmp_chardev_add(const char *id, ChardevBackend *backend,
chr->label = g_strdup(id);
chr->avail_connections =
(backend->kind == CHARDEV_BACKEND_KIND_MUX) ? MAX_MUX : 1;
+ if (!chr->filename) {
+ chr->filename = g_strdup(ChardevBackendKind_lookup[backend->kind]);
+ }
QTAILQ_INSERT_TAIL(&chardevs, chr, next);
return ret;
} else {
--
1.7.9.7
next prev parent reply other threads:[~2013-05-28 10:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 10:27 [Qemu-devel] [PULL 0/2] chardev: fix "info chardev" output Gerd Hoffmann
2013-05-28 10:27 ` [Qemu-devel] [PATCH 1/2] Revert "chardev: Get filename for new qapi backend" Gerd Hoffmann
2013-05-28 10:27 ` Gerd Hoffmann [this message]
2013-05-28 10:31 ` [Qemu-devel] [SeaBIOS] [PULL 0/2] chardev: fix "info chardev" output Gerd Hoffmann
2013-06-17 21:18 ` [Qemu-devel] " Anthony Liguori
-- strict thread matches above, loose matches on Subject: below --
2013-05-28 6:34 Gerd Hoffmann
2013-05-28 6:34 ` [Qemu-devel] [PATCH 2/2] " Gerd Hoffmann
2013-05-28 9:57 ` Gerd Hoffmann
2013-05-31 12:36 ` Eric Blake
2013-05-31 12:45 ` Peter Krempa
2013-05-31 13:21 ` Gerd Hoffmann
2013-05-31 13:30 ` Peter Krempa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369736879-16503-3-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=aliguori@us.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=seabios@seabios.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).