From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51532)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UhIjC-0002pV-0l
	for qemu-devel@nongnu.org; Tue, 28 May 2013 08:10:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UhIj1-0000D9-E6
	for qemu-devel@nongnu.org; Tue, 28 May 2013 08:10:09 -0400
Received: from mx1.redhat.com ([209.132.183.28]:17677)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <alevy@redhat.com>) id 1UhIj1-0000Ch-6g
	for qemu-devel@nongnu.org; Tue, 28 May 2013 08:09:59 -0400
Received: from int-mx11.intmail.prod.int.phx2.redhat.com
	(int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24])
	by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r4SC9wWh022483
	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK)
	for <qemu-devel@nongnu.org>; Tue, 28 May 2013 08:09:58 -0400
Message-ID: <1369742995.31959.1.camel@localhost>
From: Alon Levy <alevy@redhat.com>
Date: Tue, 28 May 2013 08:09:55 -0400
In-Reply-To: <51A2FE14.2050501@redhat.com>
References: <1369621146-17095-1-git-send-email-alevy@redhat.com>
	<51A2FE14.2050501@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [RFC] Add a stp file for usage from build directory
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org

On Mon, 2013-05-27 at 08:32 +0200, Paolo Bonzini wrote:
> Il 27/05/2013 04:19, Alon Levy ha scritto:
> > For systemtap the location of the process being tapped is crucial, so
> > the existing stp file requires installation to use. A new file providing
> > qemu.local prefixed probes lets scripts run without an install step.
> > 
> > Signed-off-by: Alon Levy <alevy@redhat.com>
> > ---
> > 
> >  Makefile.target | 13 ++++++++++++-
> >  1 file changed, 12 insertions(+), 1 deletion(-)
> > 
> > diff --git a/Makefile.target b/Makefile.target
> > index ce4391f..5d176e2 100644
> > --- a/Makefile.target
> > +++ b/Makefile.target
> > @@ -35,7 +35,7 @@ config-target.h: config-target.h-timestamp
> >  config-target.h-timestamp: config-target.mak
> >  
> >  ifdef CONFIG_TRACE_SYSTEMTAP
> > -stap: $(QEMU_PROG).stp
> > +stap: $(QEMU_PROG).stp $(QEMU_PROG).local.stp
> >  
> >  ifdef CONFIG_USER_ONLY
> >  TARGET_TYPE=user
> > @@ -51,6 +51,17 @@ $(QEMU_PROG).stp: $(SRC_PATH)/trace-events
> >  		--target-arch=$(TARGET_ARCH) \
> >  		--target-type=$(TARGET_TYPE) \
> >  		< $< > $@,"  GEN   $(TARGET_DIR)$(QEMU_PROG).stp")
> > +
> > +$(QEMU_PROG).local.stp: $(SRC_PATH)/trace-events
> > +	$(call quiet-command,$(TRACETOOL) \
> > +		--format=stap \
> > +		--backend=$(TRACE_BACKEND) \
> > +		--binary=$(SRC_PATH)/$(TARGET_DIR)$(QEMU_PROG) \
> 
> This is not the build directory for out-of-tree builds.

I'll fix that.

> 
> > +		--probe-prefix=qemu.local \
> 
> Why change the prefix?

It was one way to verify I was using the correct file. I'll change it
back.

But in general does it make sense for you to have this in addition to
the existing stp file?

> 
> Paolo
> 
> > +		--target-arch=$(TARGET_ARCH) \
> > +		--target-type=$(TARGET_TYPE) \
> > +		< $< > $@,"  GEN   $(TARGET_DIR)$(QEMU_PROG).local.stp")
> > +
> >  else
> >  stap:
> >  endif
> > 
> 
>