qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, "Qiao Nuohan" <qiaonuohan@cn.fujitsu.com>,
	"Andreas Färber" <afaerber@suse.de>
Subject: [Qemu-devel] [PATCH qom-cpu v2 1/7] target-i386: Fix mask of pte index in memory mapping
Date: Tue, 28 May 2013 17:05:20 +0200	[thread overview]
Message-ID: <1369753526-7020-2-git-send-email-afaerber@suse.de> (raw)
In-Reply-To: <1369753526-7020-1-git-send-email-afaerber@suse.de>

From: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>

Function walk_pte() needs pte index to calculate virtual address.
However, pte index of PAE paging or IA-32e paging is 9 bit, so the mask
should be 0x1ff.

Signed-off-by: Qiao Nuohan <qiaonuohan@cn.fujitsu.com>
Reviewed-by: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 target-i386/arch_memory_mapping.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target-i386/arch_memory_mapping.c b/target-i386/arch_memory_mapping.c
index 844893f..a2eb7e7 100644
--- a/target-i386/arch_memory_mapping.c
+++ b/target-i386/arch_memory_mapping.c
@@ -38,7 +38,7 @@ static void walk_pte(MemoryMappingList *list, hwaddr pte_start_addr,
             continue;
         }
 
-        start_vaddr = start_line_addr | ((i & 0x1fff) << 12);
+        start_vaddr = start_line_addr | ((i & 0x1ff) << 12);
         memory_mapping_list_add_merge_sorted(list, start_paddr,
                                              start_vaddr, 1 << 12);
     }
-- 
1.8.1.4

  reply	other threads:[~2013-05-28 15:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-28 15:05 [Qemu-devel] [PATCH qom-cpu v2 0/7] dump: Build cleanups redone Andreas Färber
2013-05-28 15:05 ` Andreas Färber [this message]
2013-05-28 15:05 ` [Qemu-devel] [PATCH qom-cpu v2 2/7] dump: Move stubs into libqemustub.a Andreas Färber
2013-05-28 15:05 ` [Qemu-devel] [PATCH qom-cpu v2 3/7] cpu: Turn cpu_paging_enabled() into a CPUState hook Andreas Färber
2013-05-28 15:05 ` [Qemu-devel] [PATCH qom-cpu v2 4/7] memory_mapping: Move MemoryMappingList typedef to qemu/typedefs.h Andreas Färber
2013-05-28 15:05 ` [Qemu-devel] [PATCH qom-cpu v2 5/7] cpu: Turn cpu_get_memory_mapping() into a CPUState hook Andreas Färber
2013-05-28 15:05 ` [Qemu-devel] [PATCH qom-cpu v2 6/7] memory_mapping: Drop qemu_get_memory_mapping() stub Andreas Färber
2013-05-28 15:05 ` [Qemu-devel] [PATCH qom-cpu v2 7/7] dump: Unconditionally compile Andreas Färber

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369753526-7020-2-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qiaonuohan@cn.fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).