From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:52404) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhee2-0001YD-DL for qemu-devel@nongnu.org; Wed, 29 May 2013 07:34:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Uhedy-0001OT-DB for qemu-devel@nongnu.org; Wed, 29 May 2013 07:34:18 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Uhedy-0001ON-5U for qemu-devel@nongnu.org; Wed, 29 May 2013 07:34:14 -0400 From: Kevin Wolf Date: Wed, 29 May 2013 13:34:05 +0200 Message-Id: <1369827246-2802-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1369827246-2802-1-git-send-email-kwolf@redhat.com> References: <1369827246-2802-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH 2/3] ide: Set BSY bit during FLUSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, afaerber@suse.de, stefanha@redhat.com From: Andreas F=C3=A4rber The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11 SP1 guest driver reports I/O errors and filesystems get corrupted or remounted read-only. Avoid this by setting BUSY_STAT, so that the guest is made aware we are in the middle of an operation and no ATA commands are attempted to be processed concurrently. Addresses BNC#637297. Suggested-by: Gonglei (Arei) Signed-off-by: Andreas F=C3=A4rber Signed-off-by: Kevin Wolf --- hw/ide/core.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index c7a8041..bf1ff18 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -795,6 +795,8 @@ static void ide_flush_cb(void *opaque, int ret) { IDEState *s =3D opaque; =20 + s->status &=3D ~BUSY_STAT; + if (ret < 0) { /* XXX: What sector number to set here? */ if (ide_handle_rw_error(s, -ret, BM_STATUS_RETRY_FLUSH)) { @@ -814,6 +816,7 @@ void ide_flush_cache(IDEState *s) return; } =20 + s->status |=3D BUSY_STAT; bdrv_acct_start(s->bs, &s->acct, 0, BDRV_ACCT_FLUSH); bdrv_aio_flush(s->bs, ide_flush_cb, s); } --=20 1.8.1.4