* [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
@ 2013-05-29 13:30 Alexey Kardashevskiy
2013-05-31 11:56 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
0 siblings, 1 reply; 7+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-29 13:30 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell
Cc: Alexey Kardashevskiy, qemu-trivial, qemu-devel
The symlink to "asm" platform linux headers is made in the build tree by
the configure script but gcc is not told to look for them there.
The patch fixes this.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
Reposting it as a top level patch.
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 5ae7e4a..eca2a20 100755
--- a/configure
+++ b/configure
@@ -547,7 +547,7 @@ Haiku)
if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
audio_possible_drivers="$audio_possible_drivers fmod"
fi
- QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
+ QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
;;
esac
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Qemu-devel] [PATCH v2] qemu: fix out of tree cross compile
@ 2013-05-27 23:44 Alexey Kardashevskiy
2013-05-27 23:49 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
0 siblings, 1 reply; 7+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-27 23:44 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell
Cc: Alexey Kardashevskiy, qemu-trivial, qemu-devel
The symlink to "asm" platform linux headers is made in the build tree by
the configure script but gcc is not told to look for them there.
The patch fixes this.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
configure | 1 +
1 file changed, 1 insertion(+)
diff --git a/configure b/configure
index 5ae7e4a..20b42f0 100755
--- a/configure
+++ b/configure
@@ -548,6 +548,7 @@ Haiku)
audio_possible_drivers="$audio_possible_drivers fmod"
fi
QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
+ QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
;;
esac
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-27 23:44 [Qemu-devel] [PATCH v2] " Alexey Kardashevskiy
@ 2013-05-27 23:49 ` Alexey Kardashevskiy
2013-05-28 8:54 ` Paolo Bonzini
2013-05-29 13:17 ` Anthony Liguori
0 siblings, 2 replies; 7+ messages in thread
From: Alexey Kardashevskiy @ 2013-05-27 23:49 UTC (permalink / raw)
To: Paolo Bonzini, Peter Maydell
Cc: Alexey Kardashevskiy, qemu-trivial, qemu-devel
The symlink to "asm" platform linux headers is made in the build tree by
the configure script but gcc is not told to look for them there.
The patch fixes this.
Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
---
The previous patch did not remove the old line adding includes. Early morning,
lack of focus :)
---
configure | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/configure b/configure
index 5ae7e4a..eca2a20 100755
--- a/configure
+++ b/configure
@@ -547,7 +547,7 @@ Haiku)
if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
audio_possible_drivers="$audio_possible_drivers fmod"
fi
- QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
+ QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
;;
esac
--
1.7.10.4
^ permalink raw reply related [flat|nested] 7+ messages in thread* Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-27 23:49 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
@ 2013-05-28 8:54 ` Paolo Bonzini
2013-05-28 9:12 ` Andreas Färber
2013-05-29 13:17 ` Anthony Liguori
1 sibling, 1 reply; 7+ messages in thread
From: Paolo Bonzini @ 2013-05-28 8:54 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: qemu-trivial, Peter Maydell, qemu-devel
Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto:
> The symlink to "asm" platform linux headers is made in the build tree by
> the configure script but gcc is not told to look for them there.
>
> The patch fixes this.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>
> The previous patch did not remove the old line adding includes. Early morning,
> lack of focus :)
>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5ae7e4a..eca2a20 100755
> --- a/configure
> +++ b/configure
> @@ -547,7 +547,7 @@ Haiku)
> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
> audio_possible_drivers="$audio_possible_drivers fmod"
> fi
> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
> ;;
> esac
>
>
Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-28 8:54 ` Paolo Bonzini
@ 2013-05-28 9:12 ` Andreas Färber
2013-05-28 9:21 ` Paolo Bonzini
0 siblings, 1 reply; 7+ messages in thread
From: Andreas Färber @ 2013-05-28 9:12 UTC (permalink / raw)
To: Paolo Bonzini, Alexey Kardashevskiy
Cc: qemu-trivial, Peter Maydell, qemu-devel
Am 28.05.2013 10:54, schrieb Paolo Bonzini:
> Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto:
>> The symlink to "asm" platform linux headers is made in the build tree by
>> the configure script but gcc is not told to look for them there.
>>
>> The patch fixes this.
>>
>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>> ---
>>
>> The previous patch did not remove the old line adding includes. Early morning,
>> lack of focus :)
>>
>> ---
>> configure | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/configure b/configure
>> index 5ae7e4a..eca2a20 100755
>> --- a/configure
>> +++ b/configure
>> @@ -547,7 +547,7 @@ Haiku)
>> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
>> audio_possible_drivers="$audio_possible_drivers fmod"
>> fi
>> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
>> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
>> ;;
>> esac
>>
>>
>
> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
Hm, I see no other case of adding $(pwd) to QEMU_INCLUDES - shouldn't
this just be -Ilinux-headers?
And might it make sense to give the build directory precedence over the
source directory?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-28 9:12 ` Andreas Färber
@ 2013-05-28 9:21 ` Paolo Bonzini
0 siblings, 0 replies; 7+ messages in thread
From: Paolo Bonzini @ 2013-05-28 9:21 UTC (permalink / raw)
To: Andreas Färber
Cc: Alexey Kardashevskiy, qemu-trivial, qemu-devel, Peter Maydell
Il 28/05/2013 11:12, Andreas Färber ha scritto:
> Am 28.05.2013 10:54, schrieb Paolo Bonzini:
>> Il 28/05/2013 01:49, Alexey Kardashevskiy ha scritto:
>>> The symlink to "asm" platform linux headers is made in the build tree by
>>> the configure script but gcc is not told to look for them there.
>>>
>>> The patch fixes this.
>>>
>>> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
>>> ---
>>>
>>> The previous patch did not remove the old line adding includes. Early morning,
>>> lack of focus :)
>>>
>>> ---
>>> configure | 2 +-
>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/configure b/configure
>>> index 5ae7e4a..eca2a20 100755
>>> --- a/configure
>>> +++ b/configure
>>> @@ -547,7 +547,7 @@ Haiku)
>>> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
>>> audio_possible_drivers="$audio_possible_drivers fmod"
>>> fi
>>> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
>>> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
>>> ;;
>>> esac
>>>
>>>
>>
>> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Hm, I see no other case of adding $(pwd) to QEMU_INCLUDES - shouldn't
> this just be -Ilinux-headers?
I think -Ilinux-headers would add
<builddir>/x86_64-softmmu/linux-headers, which is wrong.
> And might it make sense to give the build directory precedence over the
> source directory?
It shouldn't matter.
Paolo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile
2013-05-27 23:49 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
2013-05-28 8:54 ` Paolo Bonzini
@ 2013-05-29 13:17 ` Anthony Liguori
1 sibling, 0 replies; 7+ messages in thread
From: Anthony Liguori @ 2013-05-29 13:17 UTC (permalink / raw)
To: Alexey Kardashevskiy, Paolo Bonzini, Peter Maydell
Cc: qemu-trivial, qemu-devel
Alexey Kardashevskiy <aik@ozlabs.ru> writes:
> The symlink to "asm" platform linux headers is made in the build tree by
> the configure script but gcc is not told to look for them there.
>
> The patch fixes this.
>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>
> The previous patch did not remove the old line adding includes. Early morning,
> lack of focus :)
Please repost as a top level patch.
Regards,
Anthony Liguori
>
> ---
> configure | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/configure b/configure
> index 5ae7e4a..eca2a20 100755
> --- a/configure
> +++ b/configure
> @@ -547,7 +547,7 @@ Haiku)
> if [ "$cpu" = "i386" -o "$cpu" = "x86_64" ] ; then
> audio_possible_drivers="$audio_possible_drivers fmod"
> fi
> - QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers $QEMU_INCLUDES"
> + QEMU_INCLUDES="-I\$(SRC_PATH)/linux-headers -I$(pwd)/linux-headers $QEMU_INCLUDES"
> ;;
> esac
>
> --
> 1.7.10.4
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2013-05-31 11:56 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-29 13:30 [Qemu-devel] [PATCH v3] qemu: fix out of tree cross compile Alexey Kardashevskiy
2013-05-31 11:56 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
-- strict thread matches above, loose matches on Subject: below --
2013-05-27 23:44 [Qemu-devel] [PATCH v2] " Alexey Kardashevskiy
2013-05-27 23:49 ` [Qemu-devel] [PATCH v3] " Alexey Kardashevskiy
2013-05-28 8:54 ` Paolo Bonzini
2013-05-28 9:12 ` Andreas Färber
2013-05-28 9:21 ` Paolo Bonzini
2013-05-29 13:17 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).