* [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a
@ 2013-05-29 13:58 Ed Maste
2013-05-31 11:57 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-04 11:31 ` [Qemu-devel] " Peter Crosthwaite
0 siblings, 2 replies; 4+ messages in thread
From: Ed Maste @ 2013-05-29 13:58 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial, Ed Maste
Based on the datasheet at
http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf
Signed-off-by: Ed Maste <emaste@freebsd.org>
---
hw/block/m25p80.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
index 759c84d..a927a6b 100644
--- a/hw/block/m25p80.c
+++ b/hw/block/m25p80.c
@@ -123,6 +123,7 @@ static const FlashPartInfo known_devices[] = {
{ INFO("mx25l25655e", 0xc22619, 0, 64 << 10, 512, 0) },
/* Micron */
+ { INFO("n25q032a", 0x20bb16, 0, 64 << 10, 64, ER_4K) },
{ INFO("n25q128a11", 0x20bb18, 0, 64 << 10, 256, 0) },
{ INFO("n25q128a13", 0x20ba18, 0, 64 << 10, 256, 0) },
{ INFO("n25q256a", 0x20ba19, 0, 64 << 10, 512, ER_4K) },
--
1.7.11.5
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [Qemu-trivial] [PATCH] m25p80: Add Micron n25q032a
2013-05-29 13:58 [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a Ed Maste
@ 2013-05-31 11:57 ` Michael Tokarev
2013-06-04 11:31 ` [Qemu-devel] " Peter Crosthwaite
1 sibling, 0 replies; 4+ messages in thread
From: Michael Tokarev @ 2013-05-31 11:57 UTC (permalink / raw)
To: Ed Maste; +Cc: qemu-trivial, qemu-devel
29.05.2013 17:58, Ed Maste wrote:
> Based on the datasheet at
> http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf
Thanks, applied to the trivial patches queue.
/mjt
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a
2013-05-29 13:58 [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a Ed Maste
2013-05-31 11:57 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
@ 2013-06-04 11:31 ` Peter Crosthwaite
2013-06-04 14:32 ` Ed Maste
1 sibling, 1 reply; 4+ messages in thread
From: Peter Crosthwaite @ 2013-06-04 11:31 UTC (permalink / raw)
To: Ed Maste; +Cc: qemu-trivial, suneelg, qemu-devel
Hi Ed,
On Wed, May 29, 2013 at 11:58 PM, Ed Maste <emaste@freebsd.org> wrote:
> Based on the datasheet at
> http://www.micron.com/~/media/Documents/Products/Data%20Sheet/NOR%20Flash/Serial%20NOR/N25Q/n25q_32mb_1_8v_65nm.pdf
>
> Signed-off-by: Ed Maste <emaste@freebsd.org>
> ---
> hw/block/m25p80.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c
> index 759c84d..a927a6b 100644
> --- a/hw/block/m25p80.c
> +++ b/hw/block/m25p80.c
> @@ -123,6 +123,7 @@ static const FlashPartInfo known_devices[] = {
> { INFO("mx25l25655e", 0xc22619, 0, 64 << 10, 512, 0) },
>
> /* Micron */
> + { INFO("n25q032a", 0x20bb16, 0, 64 << 10, 64, ER_4K) },
Does this have a11 and a13 variants as well?
> { INFO("n25q128a11", 0x20bb18, 0, 64 << 10, 256, 0) },
> { INFO("n25q128a13", 0x20ba18, 0, 64 << 10, 256, 0) },
And this looks odd, these parts don't support 4K erase as well?
Regards,
Peter
> { INFO("n25q256a", 0x20ba19, 0, 64 << 10, 512, ER_4K) },
> --
> 1.7.11.5
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a
2013-06-04 11:31 ` [Qemu-devel] " Peter Crosthwaite
@ 2013-06-04 14:32 ` Ed Maste
0 siblings, 0 replies; 4+ messages in thread
From: Ed Maste @ 2013-06-04 14:32 UTC (permalink / raw)
To: Peter Crosthwaite; +Cc: qemu-trivial, suneelg, qemu-devel
On 4 June 2013 07:31, Peter Crosthwaite <peter.crosthwaite@xilinx.com> wrote:
>> /* Micron */
>> + { INFO("n25q032a", 0x20bb16, 0, 64 << 10, 64, ER_4K) },
>
> Does this have a11 and a13 variants as well?
>
>> { INFO("n25q128a11", 0x20bb18, 0, 64 << 10, 256, 0) },
>> { INFO("n25q128a13", 0x20ba18, 0, 64 << 10, 256, 0) },
>
> And this looks odd, these parts don't support 4K erase as well?
You're correct on both counts - I originally added the n25q032a based
on the n25q256a entry, then sync'd the list with the one from the
Linux kernel, and it's missing the 4K sector erase flag. I'll send a
followup patch to update all of the Micron entries.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2013-06-04 14:33 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-05-29 13:58 [Qemu-devel] [PATCH] m25p80: Add Micron n25q032a Ed Maste
2013-05-31 11:57 ` [Qemu-devel] [Qemu-trivial] " Michael Tokarev
2013-06-04 11:31 ` [Qemu-devel] " Peter Crosthwaite
2013-06-04 14:32 ` Ed Maste
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).