From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:44401) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui2Bg-0008BA-0J for qemu-devel@nongnu.org; Thu, 30 May 2013 08:42:43 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ui2BZ-0001Kl-QQ for qemu-devel@nongnu.org; Thu, 30 May 2013 08:42:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48725) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ui24h-0005z7-Tj for qemu-devel@nongnu.org; Thu, 30 May 2013 08:35:24 -0400 From: Stefan Hajnoczi Date: Thu, 30 May 2013 14:34:53 +0200 Message-Id: <1369917299-5725-6-git-send-email-stefanha@redhat.com> In-Reply-To: <1369917299-5725-1-git-send-email-stefanha@redhat.com> References: <1369917299-5725-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH v5 05/11] blockdev: use bdrv_getlength() in qmp_drive_mirror() List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Fam Zheng , xiawenc@linux.vnet.ibm.com, imain@redhat.com, Stefan Hajnoczi , Paolo Bonzini , dietmar@proxmox.com Use bdrv_getlength() for its byte units and error return instead of bdrv_get_geometry(). Reported-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- blockdev.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index 01db519..73b175b 100644 --- a/blockdev.c +++ b/blockdev.c @@ -1364,7 +1364,7 @@ void qmp_drive_mirror(const char *device, const char *target, BlockDriver *drv = NULL; Error *local_err = NULL; int flags; - uint64_t size; + int64_t size; int ret; if (!has_speed) { @@ -1428,8 +1428,12 @@ void qmp_drive_mirror(const char *device, const char *target, sync = MIRROR_SYNC_MODE_FULL; } - bdrv_get_geometry(bs, &size); - size *= 512; + size = bdrv_getlength(bs); + if (size < 0) { + error_setg_errno(errp, -size, "bdrv_getlength failed"); + return; + } + if (sync == MIRROR_SYNC_MODE_FULL && mode != NEW_IMAGE_MODE_EXISTING) { /* create new image w/o backing file */ assert(format && drv); -- 1.8.1.4