qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PATCH 3/3] fw_cfg: fw_cfg is a singleton
Date: Thu, 30 May 2013 16:28:03 +0300	[thread overview]
Message-ID: <1369920427-18274-4-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1369920427-18274-1-git-send-email-mst@redhat.com>

Make sure we only have a single instance ever:
because if it isn't we can't find it so it's
useless anyway.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 hw/nvram/fw_cfg.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/hw/nvram/fw_cfg.c b/hw/nvram/fw_cfg.c
index df3f089..3c255ce 100644
--- a/hw/nvram/fw_cfg.c
+++ b/hw/nvram/fw_cfg.c
@@ -496,10 +496,9 @@ FWCfgState *fw_cfg_init(uint32_t ctl_port, uint32_t data_port,
 
     s = DO_UPCAST(FWCfgState, busdev.qdev, dev);
 
-    if (!object_resolve_path(FW_CFG_PATH, NULL)) {
-        object_property_add_child(qdev_get_machine(), FW_CFG_NAME, OBJECT(s),
-                                  NULL);
-    }
+    assert(!object_resolve_path(FW_CFG_PATH, NULL));
+
+    object_property_add_child(qdev_get_machine(), FW_CFG_NAME, OBJECT(s), NULL);
 
     qdev_init_nofail(dev);
 
-- 
MST

  parent reply	other threads:[~2013-05-30 13:27 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-30 13:27 [Qemu-devel] [PATCH 0/3] fw_cfg: misc fixes Michael S. Tsirkin
2013-05-30 13:27 ` [Qemu-devel] [PATCH 1/3] pvpanic: use FWCfgState explicitly Michael S. Tsirkin
2013-05-30 15:05   ` Laszlo Ersek
2013-05-30 15:41     ` Paolo Bonzini
2013-05-30 15:56       ` Laszlo Ersek
2013-05-30 16:03     ` Laszlo Ersek
2013-05-30 16:01       ` Paolo Bonzini
2013-05-30 17:36     ` Michael S. Tsirkin
2013-05-30 13:28 ` [Qemu-devel] [PATCH 2/3] fw_cfg: add API to find FW cfg object Michael S. Tsirkin
2013-05-30 16:06   ` Laszlo Ersek
2013-05-31  1:47   ` Hu Tao
2013-05-30 13:28 ` Michael S. Tsirkin [this message]
2013-05-30 16:06 ` [Qemu-devel] [PATCH 0/3] fw_cfg: misc fixes Laszlo Ersek
2013-05-31  1:51 ` Hu Tao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1369920427-18274-4-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).