From: Fabien Chouteau <chouteau@adacore.com>
To: qemu-devel@nongnu.org
Cc: blauwirbel@gmail.com, peter.maydell@linaro.org,
pbonzini@redhat.com, afaerber@suse.de, rth@twiddle.net
Subject: [Qemu-devel] [PATCH] ARM: Fix disable interrupt for M profile
Date: Thu, 30 May 2013 18:22:30 +0200 [thread overview]
Message-ID: <1369930950-18564-1-git-send-email-chouteau@adacore.com> (raw)
I'm not sure this was expected or not, but it looks like the "||" should
be a "&&". Otherwise it's not possible to disable interrupt.
Signed-off-by: Fabien Chouteau <chouteau@adacore.com>
---
cpu-exec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/cpu-exec.c b/cpu-exec.c
index 31c089d..079b6f0 100644
--- a/cpu-exec.c
+++ b/cpu-exec.c
@@ -462,8 +462,8 @@ int cpu_exec(CPUArchState *env)
We avoid this by disabling interrupts when
pc contains a magic address. */
if (interrupt_request & CPU_INTERRUPT_HARD
- && ((IS_M(env) && env->regs[15] < 0xfffffff0)
- || !(env->uncached_cpsr & CPSR_I))) {
+ && (IS_M(env) && env->regs[15] < 0xfffffff0)
+ && !(env->uncached_cpsr & CPSR_I)) {
env->exception_index = EXCP_IRQ;
cc->do_interrupt(cpu);
next_tb = 0;
--
1.7.9.5
next reply other threads:[~2013-05-30 16:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-30 16:22 Fabien Chouteau [this message]
2013-05-30 17:26 ` [Qemu-devel] [PATCH] ARM: Fix disable interrupt for M profile Peter Maydell
2013-05-31 9:04 ` Fabien Chouteau
2013-05-31 9:39 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1369930950-18564-1-git-send-email-chouteau@adacore.com \
--to=chouteau@adacore.com \
--cc=afaerber@suse.de \
--cc=blauwirbel@gmail.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).