qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 6/9] fw_cfg: move typedef to qemu/typedefs.h
Date: Tue, 4 Jun 2013 11:07:58 +0300	[thread overview]
Message-ID: <1370202787-3712-7-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1370202787-3712-1-git-send-email-mst@redhat.com>

Less header dependencies this way.

Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
 include/hw/i386/pc.h      | 1 -
 include/hw/nvram/fw_cfg.h | 2 +-
 include/qemu/typedefs.h   | 1 +
 3 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index fa3bf24..b4c8a74 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -8,7 +8,6 @@
 #include "hw/block/fdc.h"
 #include "net/net.h"
 #include "hw/i386/ioapic.h"
-#include "hw/nvram/fw_cfg.h"
 
 /* PC-style peripherals (also used by other machines).  */
 
diff --git a/include/hw/nvram/fw_cfg.h b/include/hw/nvram/fw_cfg.h
index 3e4a334..f37714e 100644
--- a/include/hw/nvram/fw_cfg.h
+++ b/include/hw/nvram/fw_cfg.h
@@ -6,6 +6,7 @@
 #include <stddef.h>
 
 #include "exec/hwaddr.h"
+#include "qemu/typedefs.h"
 #endif
 
 #define FW_CFG_SIGNATURE        0x00
@@ -60,7 +61,6 @@ typedef struct FWCfgFiles {
 
 typedef void (*FWCfgCallback)(void *opaque, uint8_t *data);
 
-typedef struct FWCfgState FWCfgState;
 void fw_cfg_add_bytes(FWCfgState *s, uint16_t key, void *data, size_t len);
 void fw_cfg_add_string(FWCfgState *s, uint16_t key, const char *value);
 void fw_cfg_add_i16(FWCfgState *s, uint16_t key, uint16_t value);
diff --git a/include/qemu/typedefs.h b/include/qemu/typedefs.h
index 93aae81..afe4ec7 100644
--- a/include/qemu/typedefs.h
+++ b/include/qemu/typedefs.h
@@ -61,5 +61,6 @@ typedef struct EventNotifier EventNotifier;
 typedef struct VirtIODevice VirtIODevice;
 typedef struct QEMUSGList QEMUSGList;
 typedef struct SHPCDevice SHPCDevice;
+typedef struct FWCfgState FWCfgState;
 
 #endif /* QEMU_TYPEDEFS_H */
-- 
MST

  parent reply	other threads:[~2013-06-04  8:07 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-04  8:07 [Qemu-devel] [PULL 0/9] pci: misc cleanups Michael S. Tsirkin
2013-06-04  8:07 ` [Qemu-devel] [PULL 1/9] q35: set fw_name Michael S. Tsirkin
2013-06-04  8:07 ` [Qemu-devel] [PULL 2/9] dec.c - move to pci-bridge Michael S. Tsirkin
2013-06-04  8:07 ` [Qemu-devel] [PULL 3/9] firmware_abi: move to include/hw/nvram/ Michael S. Tsirkin
2013-06-04  8:07 ` [Qemu-devel] [PULL 4/9] apic: rename apic specific bitopts Michael S. Tsirkin
2013-06-04  8:07 ` [Qemu-devel] [PULL 5/9] refer to FWCfgState explicitly Michael S. Tsirkin
2013-06-04  8:07 ` Michael S. Tsirkin [this message]
2013-06-04  8:08 ` [Qemu-devel] [PULL 7/9] fw_cfg: add API to find FW cfg object Michael S. Tsirkin
2013-06-04  8:08 ` [Qemu-devel] [PULL 8/9] fw_cfg: fw_cfg is a singleton Michael S. Tsirkin
2013-06-04  8:08 ` [Qemu-devel] [PULL 9/9] pvpanic: use FWCfgState explicitly Michael S. Tsirkin
2013-06-17 21:17 ` [Qemu-devel] [PULL 0/9] pci: misc cleanups Anthony Liguori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370202787-3712-7-git-send-email-mst@redhat.com \
    --to=mst@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).