From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Michael Marineau <mike@marineau.org>,
qemu-stable@nongnu.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH 1/7] Fix usage of USB_DEV_FLAG_IS_HOST flag.
Date: Mon, 3 Jun 2013 12:05:45 +0200 [thread overview]
Message-ID: <1370253951-12323-2-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1370253951-12323-1-git-send-email-kraxel@redhat.com>
From: Michael Marineau <mike@marineau.org>
USB_DEV_FLAG_IS_HOST is the bit number, not value. Booting with a
"Fitbit Base Station" USB dongle was triggering this assert.
Signed-off-by: Michael Marineau <mike@marineau.org>
Cc: qemu-stable@nongnu.org
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/usb/core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/usb/core.c b/hw/usb/core.c
index 15a150a..05948ca 100644
--- a/hw/usb/core.c
+++ b/hw/usb/core.c
@@ -410,7 +410,7 @@ void usb_handle_packet(USBDevice *dev, USBPacket *p)
assert(p->ep->type != USB_ENDPOINT_XFER_ISOC);
/* using async for interrupt packets breaks migration */
assert(p->ep->type != USB_ENDPOINT_XFER_INT ||
- (dev->flags & USB_DEV_FLAG_IS_HOST));
+ (dev->flags & (1 << USB_DEV_FLAG_IS_HOST)));
usb_packet_set_state(p, USB_PACKET_ASYNC);
QTAILQ_INSERT_TAIL(&p->ep->queue, p, queue);
} else if (p->status == USB_RET_ADD_TO_QUEUE) {
--
1.7.9.7
next prev parent reply other threads:[~2013-06-03 10:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-03 10:05 [Qemu-devel] [PULL 0/7] usb patch queue Gerd Hoffmann
2013-06-03 10:05 ` Gerd Hoffmann [this message]
2013-06-03 10:05 ` [Qemu-devel] [PATCH 2/7] host-libusb: Correct test for USB packet state Gerd Hoffmann
2013-06-03 10:05 ` [Qemu-devel] [PATCH 3/7] pci: add VMSTATE_MSIX Gerd Hoffmann
2013-06-03 10:05 ` [Qemu-devel] [PATCH 4/7] xhci: add XHCISlot->addressed Gerd Hoffmann
2013-06-03 10:05 ` [Qemu-devel] [PATCH 5/7] xhci: add xhci_alloc_epctx Gerd Hoffmann
2013-06-03 10:05 ` [Qemu-devel] [PATCH 6/7] xhci: add xhci_init_epctx Gerd Hoffmann
2013-06-03 10:05 ` [Qemu-devel] [PATCH 7/7] xhci: add live migration support Gerd Hoffmann
2013-06-17 21:18 ` [Qemu-devel] [PULL 0/7] usb patch queue Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370253951-12323-2-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=mike@marineau.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).