From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44345) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjWLn-0007yH-BR for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:07:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjWLi-000306-Ov for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:07:11 -0400 Received: from mail-wi0-x231.google.com ([2a00:1450:400c:c05::231]:46026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjWLi-0002zp-JY for qemu-devel@nongnu.org; Mon, 03 Jun 2013 11:07:06 -0400 Received: by mail-wi0-f177.google.com with SMTP id hr14so2767427wib.10 for ; Mon, 03 Jun 2013 08:07:06 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 3 Jun 2013 17:06:54 +0200 Message-Id: <1370272015-9659-2-git-send-email-pbonzini@redhat.com> In-Reply-To: <1370272015-9659-1-git-send-email-pbonzini@redhat.com> References: <1370272015-9659-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 1/2] gdbstub: fix for commit 87f25c12bfeaaa0c41fb857713bbc7e8a9b757dc List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: lersek@redhat.com, lcapitulino@redhat.com This commit used the wrong check to prevent an assertion failure. After this commit, you need to start a guest in the monitor, you cannot use anymore the "c" command in the debugger. This is undesirable. The commit's aim was to prevent a restart after a KVM internal error or something like that; use runstate_needs_reset() for that. Signed-off-by: Paolo Bonzini --- gdbstub.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdbstub.c b/gdbstub.c index 90e54cb..e8541f3 100644 --- a/gdbstub.c +++ b/gdbstub.c @@ -371,7 +371,7 @@ static inline void gdb_continue(GDBState *s) #ifdef CONFIG_USER_ONLY s->running_state = 1; #else - if (runstate_check(RUN_STATE_DEBUG)) { + if (!runstate_needs_reset()) { vm_start(); } #endif -- 1.8.1.4