* [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor
@ 2013-06-03 20:39 Anthony Liguori
2013-06-03 20:50 ` Peter Maydell
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2013-06-03 20:39 UTC (permalink / raw)
To: qemu-devel; +Cc: Anthony Liguori, Gerd Hoffman
It's not a GObject.
Cc: Gerd Hoffman <kraxel@redhat.com>
Reported-by: Michael Tokarev <mjt@tls.msk.ru>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
---
ui/gtk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 8dc9041..3bc2842 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
pixbuf, c->hot_x, c->hot_y);
gdk_window_set_cursor(gtk_widget_get_window(s->drawing_area), cursor);
g_object_unref(pixbuf);
- g_object_unref(cursor);
+ gdk_cursor_unref(cursor);
}
static void gd_switch(DisplayChangeListener *dcl,
--
1.8.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor
2013-06-03 20:39 [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor Anthony Liguori
@ 2013-06-03 20:50 ` Peter Maydell
2013-06-03 21:10 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Peter Maydell @ 2013-06-03 20:50 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel, Gerd Hoffman
On 3 June 2013 21:39, Anthony Liguori <aliguori@us.ibm.com> wrote:
> It's not a GObject.
>
> Cc: Gerd Hoffman <kraxel@redhat.com>
> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
> ---
> ui/gtk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/gtk.c b/ui/gtk.c
> index 8dc9041..3bc2842 100644
> --- a/ui/gtk.c
> +++ b/ui/gtk.c
> @@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
> pixbuf, c->hot_x, c->hot_y);
> gdk_window_set_cursor(gtk_widget_get_window(s->drawing_area), cursor);
> g_object_unref(pixbuf);
> - g_object_unref(cursor);
> + gdk_cursor_unref(cursor);
Function name in subject doesn't match code change :-)
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor
2013-06-03 20:50 ` Peter Maydell
@ 2013-06-03 21:10 ` Anthony Liguori
0 siblings, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2013-06-03 21:10 UTC (permalink / raw)
To: Peter Maydell; +Cc: qemu-devel, Gerd Hoffman
Peter Maydell <peter.maydell@linaro.org> writes:
> On 3 June 2013 21:39, Anthony Liguori <aliguori@us.ibm.com> wrote:
>> It's not a GObject.
>>
>> Cc: Gerd Hoffman <kraxel@redhat.com>
>> Reported-by: Michael Tokarev <mjt@tls.msk.ru>
>> Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
>> ---
>> ui/gtk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/ui/gtk.c b/ui/gtk.c
>> index 8dc9041..3bc2842 100644
>> --- a/ui/gtk.c
>> +++ b/ui/gtk.c
>> @@ -377,7 +377,7 @@ static void gd_cursor_define(DisplayChangeListener *dcl,
>> pixbuf, c->hot_x, c->hot_y);
>> gdk_window_set_cursor(gtk_widget_get_window(s->drawing_area), cursor);
>> g_object_unref(pixbuf);
>> - g_object_unref(cursor);
>> + gdk_cursor_unref(cursor);
>
> Function name in subject doesn't match code change :-)
Doh, ack.
Regards,
Anthony Liguori
>
> -- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-03 21:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-03 20:39 [Qemu-devel] [PATCH] gtk: don't use g_object_ref on GdkCursor Anthony Liguori
2013-06-03 20:50 ` Peter Maydell
2013-06-03 21:10 ` Anthony Liguori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).