From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:48010) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjqeK-000295-QR for qemu-devel@nongnu.org; Tue, 04 Jun 2013 08:47:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjqeE-0006k3-RC for qemu-devel@nongnu.org; Tue, 04 Jun 2013 08:47:40 -0400 From: Stefan Hajnoczi Date: Tue, 4 Jun 2013 14:47:26 +0200 Message-Id: <1370350046-14283-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PATCH] vmxnet3: fix NICState cleanup List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Dmitry Fleytman , Paolo Bonzini , Stefan Hajnoczi Use qemu_del_nic() instead of qemu_del_net_client() to correctly free the entire NICState. Reported-by: Paolo Bonzini Signed-off-by: Stefan Hajnoczi --- hw/net/vmxnet3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c index 5f483e7..4c575e5 100644 --- a/hw/net/vmxnet3.c +++ b/hw/net/vmxnet3.c @@ -1892,7 +1892,7 @@ static void vmxnet3_net_uninit(VMXNET3State *s) vmxnet_tx_pkt_reset(s->tx_pkt); vmxnet_tx_pkt_uninit(s->tx_pkt); vmxnet_rx_pkt_uninit(s->rx_pkt); - qemu_del_net_client(qemu_get_queue(s->nic)); + qemu_del_nic(s->nic); } static void vmxnet3_net_init(VMXNET3State *s) -- 1.8.1.4