From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:53226) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjwLs-00074m-VD for qemu-devel@nongnu.org; Tue, 04 Jun 2013 14:53:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UjwLs-0007ID-6l for qemu-devel@nongnu.org; Tue, 04 Jun 2013 14:53:00 -0400 Received: from mail-we0-x22c.google.com ([2a00:1450:400c:c03::22c]:50735) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UjwLr-0007HS-Vy for qemu-devel@nongnu.org; Tue, 04 Jun 2013 14:53:00 -0400 Received: by mail-we0-f172.google.com with SMTP id q56so555895wes.31 for ; Tue, 04 Jun 2013 11:52:59 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Tue, 4 Jun 2013 20:52:01 +0200 Message-Id: <1370371954-8479-7-git-send-email-pbonzini@redhat.com> In-Reply-To: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> References: <1370371954-8479-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PATCH 06/39] hda: split exit and instance_finalize List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: mst@redhat.com MSI is still terminated at unrealize time. Signed-off-by: Paolo Bonzini --- hw/audio/intel-hda.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/hw/audio/intel-hda.c b/hw/audio/intel-hda.c index 1016af0..4f2dcf3 100644 --- a/hw/audio/intel-hda.c +++ b/hw/audio/intel-hda.c @@ -1148,6 +1148,13 @@ static void intel_hda_exit(PCIDevice *pci) IntelHDAState *d = DO_UPCAST(IntelHDAState, pci, pci); msi_uninit(&d->pci); +} + +static void intel_hda_instance_finalize(Object *obj) +{ + PCIDevice *pci = PCI_DEVICE(obj); + IntelHDAState *d = DO_UPCAST(IntelHDAState, pci, pci); + memory_region_destroy(&d->mmio); } @@ -1273,6 +1280,7 @@ static const TypeInfo intel_hda_info_ich6 = { .parent = TYPE_PCI_DEVICE, .instance_size = sizeof(IntelHDAState), .class_init = intel_hda_class_init_ich6, + .instance_finalize = intel_hda_instance_finalize, }; static const TypeInfo intel_hda_info_ich9 = { -- 1.8.1.4