From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46487) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDTG-00039p-55 for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:09:48 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkDTC-0005gQ-TS for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:09:46 -0400 Received: from mail-qe0-f50.google.com ([209.85.128.50]:62253) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDJt-0001yf-4d for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:00:05 -0400 Received: by mail-qe0-f50.google.com with SMTP id f6so1007104qej.9 for ; Wed, 05 Jun 2013 06:00:04 -0700 (PDT) Sender: Richard Henderson From: Richard Henderson Date: Wed, 5 Jun 2013 05:59:27 -0700 Message-Id: <1370437167-11278-3-git-send-email-rth@twiddle.net> In-Reply-To: <1370437167-11278-1-git-send-email-rth@twiddle.net> References: <1370437167-11278-1-git-send-email-rth@twiddle.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: [Qemu-devel] [PULL 2/2] tcg: Remove redundant tcg_target_init checks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com We've got a compile-time check for the condition in exec/cpu-defs.h. Reviewed-by: Andreas Färber Reviewed-by: liguang Signed-off-by: Richard Henderson --- tcg/arm/tcg-target.c | 6 ------ tcg/i386/tcg-target.c | 6 ------ tcg/s390/tcg-target.c | 7 ------- 3 files changed, 19 deletions(-) diff --git a/tcg/arm/tcg-target.c b/tcg/arm/tcg-target.c index 3d43412..6be736b 100644 --- a/tcg/arm/tcg-target.c +++ b/tcg/arm/tcg-target.c @@ -2053,12 +2053,6 @@ static const TCGTargetOpDef arm_op_defs[] = { static void tcg_target_init(TCGContext *s) { -#if !defined(CONFIG_USER_ONLY) - /* fail safe */ - if ((1 << CPU_TLB_ENTRY_BITS) != sizeof(CPUTLBEntry)) - tcg_abort(); -#endif - tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xffff); tcg_regset_set32(tcg_target_call_clobber_regs, 0, (1 << TCG_REG_R0) | diff --git a/tcg/i386/tcg-target.c b/tcg/i386/tcg-target.c index 9eec06c..9e95477 100644 --- a/tcg/i386/tcg-target.c +++ b/tcg/i386/tcg-target.c @@ -2283,12 +2283,6 @@ static void tcg_target_init(TCGContext *s) } #endif -#if !defined(CONFIG_USER_ONLY) - /* fail safe */ - if ((1 << CPU_TLB_ENTRY_BITS) != sizeof(CPUTLBEntry)) - tcg_abort(); -#endif - if (TCG_TARGET_REG_BITS == 64) { tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xffff); tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I64], 0, 0xffff); diff --git a/tcg/s390/tcg-target.c b/tcg/s390/tcg-target.c index 7d6f777..f229f1c 100644 --- a/tcg/s390/tcg-target.c +++ b/tcg/s390/tcg-target.c @@ -2324,13 +2324,6 @@ static void query_facilities(void) static void tcg_target_init(TCGContext *s) { -#if !defined(CONFIG_USER_ONLY) - /* fail safe */ - if ((1 << CPU_TLB_ENTRY_BITS) != sizeof(CPUTLBEntry)) { - tcg_abort(); - } -#endif - query_facilities(); tcg_regset_set32(tcg_target_available_regs[TCG_TYPE_I32], 0, 0xffff); -- 1.8.1.4