From: Kevin Wolf <kwolf@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, afaerber@suse.de, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH v2 2/4] ide-test: Add enum value for DEV
Date: Wed, 5 Jun 2013 15:17:56 +0200 [thread overview]
Message-ID: <1370438278-1703-3-git-send-email-kwolf@redhat.com> (raw)
In-Reply-To: <1370438278-1703-1-git-send-email-kwolf@redhat.com>
Get rid of the magic number.
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
tests/ide-test.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tests/ide-test.c b/tests/ide-test.c
index 365e995..1c31a2e 100644
--- a/tests/ide-test.c
+++ b/tests/ide-test.c
@@ -64,6 +64,7 @@ enum {
};
enum {
+ DEV = 0x10,
LBA = 0x40,
};
@@ -394,7 +395,7 @@ static void test_identify(void)
/* Read in the IDENTIFY buffer and check registers */
data = inb(IDE_BASE + reg_device);
- g_assert_cmpint(data & 0x10, ==, 0);
+ g_assert_cmpint(data & DEV, ==, 0);
for (i = 0; i < 256; i++) {
data = inb(IDE_BASE + reg_status);
--
1.8.1.4
next prev parent reply other threads:[~2013-06-05 13:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-05 13:17 [Qemu-devel] [PATCH v2 0/4] ide: Set BSY bit during FLUSH Kevin Wolf
2013-06-05 13:17 ` [Qemu-devel] [PATCH v2 1/4] blkdebug: Add BLKDBG_FLUSH_TO_OS/DISK events Kevin Wolf
2013-06-05 13:17 ` Kevin Wolf [this message]
2013-06-05 13:17 ` [Qemu-devel] [PATCH v2 3/4] ide: Set BSY bit during FLUSH Kevin Wolf
2013-07-03 20:02 ` Alex Williamson
2013-07-04 7:55 ` Kevin Wolf
2013-07-10 6:27 ` Michael S. Tsirkin
2013-06-05 13:17 ` [Qemu-devel] [PATCH v2 4/4] ide-test: Add FLUSH CACHE test case Kevin Wolf
2013-06-06 8:56 ` [Qemu-devel] [PATCH v2 0/4] ide: Set BSY bit during FLUSH Stefan Hajnoczi
2013-06-06 9:44 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370438278-1703-3-git-send-email-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).