From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49360) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDbO-0001Ua-Jj for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkDbL-0000rM-4A for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51978) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDbK-0000rH-SY for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:07 -0400 From: Kevin Wolf Date: Wed, 5 Jun 2013 15:17:56 +0200 Message-Id: <1370438278-1703-3-git-send-email-kwolf@redhat.com> In-Reply-To: <1370438278-1703-1-git-send-email-kwolf@redhat.com> References: <1370438278-1703-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v2 2/4] ide-test: Add enum value for DEV List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, afaerber@suse.de, stefanha@redhat.com Get rid of the magic number. Signed-off-by: Kevin Wolf --- tests/ide-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index 365e995..1c31a2e 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -64,6 +64,7 @@ enum { }; enum { + DEV = 0x10, LBA = 0x40, }; @@ -394,7 +395,7 @@ static void test_identify(void) /* Read in the IDENTIFY buffer and check registers */ data = inb(IDE_BASE + reg_device); - g_assert_cmpint(data & 0x10, ==, 0); + g_assert_cmpint(data & DEV, ==, 0); for (i = 0; i < 256; i++) { data = inb(IDE_BASE + reg_status); -- 1.8.1.4