From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49369) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDbP-0001Vc-9H for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkDbM-0000rX-7y for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1610) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDbM-0000rT-0O for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:08 -0400 From: Kevin Wolf Date: Wed, 5 Jun 2013 15:17:57 +0200 Message-Id: <1370438278-1703-4-git-send-email-kwolf@redhat.com> In-Reply-To: <1370438278-1703-1-git-send-email-kwolf@redhat.com> References: <1370438278-1703-1-git-send-email-kwolf@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PATCH v2 3/4] ide: Set BSY bit during FLUSH List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, afaerber@suse.de, stefanha@redhat.com From: Andreas F=C3=A4rber The implementation of the ATA FLUSH command invokes a flush at the block layer, which may on raw files on POSIX entail a synchronous fdatasync(). This may in some cases take so long that the SLES 11 SP1 guest driver reports I/O errors and filesystems get corrupted or remounted read-only. Avoid this by setting BUSY_STAT, so that the guest is made aware we are in the middle of an operation and no ATA commands are attempted to be processed concurrently. Addresses BNC#637297. Suggested-by: Gonglei (Arei) Signed-off-by: Andreas F=C3=A4rber Signed-off-by: Kevin Wolf --- hw/ide/core.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/core.c b/hw/ide/core.c index c7a8041..9926d92 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -814,6 +814,7 @@ void ide_flush_cache(IDEState *s) return; } =20 + s->status |=3D BUSY_STAT; bdrv_acct_start(s->bs, &s->acct, 0, BDRV_ACCT_FLUSH); bdrv_aio_flush(s->bs, ide_flush_cb, s); } --=20 1.8.1.4