From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49367) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDbP-0001VL-5h for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkDbN-0000ro-GB for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:11 -0400 Received: from mx1.redhat.com ([209.132.183.28]:41695) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkDbN-0000re-7s for qemu-devel@nongnu.org; Wed, 05 Jun 2013 09:18:09 -0400 From: Kevin Wolf Date: Wed, 5 Jun 2013 15:17:58 +0200 Message-Id: <1370438278-1703-5-git-send-email-kwolf@redhat.com> In-Reply-To: <1370438278-1703-1-git-send-email-kwolf@redhat.com> References: <1370438278-1703-1-git-send-email-kwolf@redhat.com> Subject: [Qemu-devel] [PATCH v2 4/4] ide-test: Add FLUSH CACHE test case List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kwolf@redhat.com, afaerber@suse.de, stefanha@redhat.com This checks in particular that BSY is set while the flush request is in flight. Signed-off-by: Kevin Wolf --- tests/ide-test.c | 40 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 40 insertions(+) diff --git a/tests/ide-test.c b/tests/ide-test.c index 1c31a2e..828e71a 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -77,6 +77,7 @@ enum { enum { CMD_READ_DMA = 0xc8, CMD_WRITE_DMA = 0xca, + CMD_FLUSH_CACHE = 0xe7, CMD_IDENTIFY = 0xec, CMDF_ABORT = 0x100, @@ -424,6 +425,43 @@ static void test_identify(void) ide_test_quit(); } +static void test_flush(void) +{ + uint8_t data; + + ide_test_start( + "-vnc none " + "-drive file=blkdebug::%s,if=ide,cache=writeback", + tmp_path); + + /* Delay the completion of the flush request until we explicitly do it */ + qmp("{'execute':'human-monitor-command', 'arguments': { " + "'command-line': 'qemu-io ide0-hd0 \"break flush_to_os A\"'} }"); + + /* FLUSH CACHE command on device 0*/ + outb(IDE_BASE + reg_device, 0); + outb(IDE_BASE + reg_command, CMD_FLUSH_CACHE); + + /* Check status while request is in flight*/ + data = inb(IDE_BASE + reg_status); + assert_bit_set(data, BSY | DRDY); + assert_bit_clear(data, DF | ERR | DRQ); + + /* Complete the command */ + qmp("{'execute':'human-monitor-command', 'arguments': { " + "'command-line': 'qemu-io ide0-hd0 \"resume A\"'} }"); + + /* Check registers */ + data = inb(IDE_BASE + reg_device); + g_assert_cmpint(data & DEV, ==, 0); + + data = inb(IDE_BASE + reg_status); + assert_bit_set(data, DRDY); + assert_bit_clear(data, BSY | DF | ERR | DRQ); + + ide_test_quit(); +} + int main(int argc, char **argv) { const char *arch = qtest_get_arch(); @@ -454,6 +492,8 @@ int main(int argc, char **argv) qtest_add_func("/ide/bmdma/long_prdt", test_bmdma_long_prdt); qtest_add_func("/ide/bmdma/teardown", test_bmdma_teardown); + qtest_add_func("/ide/flush", test_flush); + ret = g_test_run(); /* Cleanup */ -- 1.8.1.4