Re: [Qemu-devel] [PATCH 2/2] KVM: PPC: Add dummy kvm_arch_init_irq_routing()

[Scott Wood <scottwood@freescale.com>]

On 06/05/2013 10:59:06 PM, Alexey Kardashevskiy wrote:
> From: Scott Wood <scottwood@freescale.com>
> 
> The common KVM code insists on calling kvm_arch_init_irq_routing()
> as soon as it sees kernel header support for it (regardless of whether
> QEMU supports it).  Provide a dummy function to satisfy this.
> 
> Unlike x86, PPC does not have one default irqchip, so there's no  
> common
> code that we'd stick here.  Even if you ignore the routes themselves,
> which even on x86 are not set up in this function, the initial XICS
> kernel implementation will not support IRQ routing, so it's best to
> leave even the general feature flags up to the specific irqchip code.
> 
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  target-ppc/kvm.c |    4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
> index 3ab2946..2bbc3b8 100644
> --- a/target-ppc/kvm.c
> +++ b/target-ppc/kvm.c
> @@ -1797,3 +1797,7 @@ int kvm_arch_on_sigbus(int code, void *addr)
>  {
>      return 1;
>  }
> +
> +void kvm_arch_init_irq_routing(KVMState *s)
> +{
> +}

This should come before the header update, to avoid breaking  
bisectability.

-Scott