From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:54211)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1Ukcbw-0001gT-R6
	for qemu-devel@nongnu.org; Thu, 06 Jun 2013 12:00:31 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <B07421@freescale.com>) id 1Ukcbq-00062E-KU
	for qemu-devel@nongnu.org; Thu, 06 Jun 2013 12:00:24 -0400
Date: Thu, 6 Jun 2013 10:59:39 -0500
From: Scott Wood <scottwood@freescale.com>
References: <1370491146-10778-1-git-send-email-aik@ozlabs.ru>
	<1370491146-10778-3-git-send-email-aik@ozlabs.ru>
In-Reply-To: <1370491146-10778-3-git-send-email-aik@ozlabs.ru> (from
	aik@ozlabs.ru on Wed Jun  5 22:59:06 2013)
Message-ID: <1370534379.21533.0@snotra>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"; delsp=Yes; format=Flowed
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH 2/2] KVM: PPC: Add dummy
	kvm_arch_init_irq_routing()
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Alexey Kardashevskiy <aik@ozlabs.ru>
Cc: Alexander Graf <agraf@suse.de>, qemu-devel@nongnu.org, qemu-trivial@nongnu.org, qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>

On 06/05/2013 10:59:06 PM, Alexey Kardashevskiy wrote:
> From: Scott Wood <scottwood@freescale.com>
>=20
> The common KVM code insists on calling kvm_arch_init_irq_routing()
> as soon as it sees kernel header support for it (regardless of whether
> QEMU supports it).  Provide a dummy function to satisfy this.
>=20
> Unlike x86, PPC does not have one default irqchip, so there's no =20
> common
> code that we'd stick here.  Even if you ignore the routes themselves,
> which even on x86 are not set up in this function, the initial XICS
> kernel implementation will not support IRQ routing, so it's best to
> leave even the general feature flags up to the specific irqchip code.
>=20
> Signed-off-by: Scott Wood <scottwood@freescale.com>
> Signed-off-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
>  target-ppc/kvm.c |    4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/target-ppc/kvm.c b/target-ppc/kvm.c
> index 3ab2946..2bbc3b8 100644
> --- a/target-ppc/kvm.c
> +++ b/target-ppc/kvm.c
> @@ -1797,3 +1797,7 @@ int kvm_arch_on_sigbus(int code, void *addr)
>  {
>      return 1;
>  }
> +
> +void kvm_arch_init_irq_routing(KVMState *s)
> +{
> +}

This should come before the header update, to avoid breaking =20
bisectability.

-Scott=