From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34689) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Ukd6q-0006E7-4D for qemu-devel@nongnu.org; Thu, 06 Jun 2013 12:32:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Ukd6i-0000AQ-OM for qemu-devel@nongnu.org; Thu, 06 Jun 2013 12:32:20 -0400 Date: Thu, 6 Jun 2013 11:31:50 -0500 From: Scott Wood In-Reply-To: <51B0761F.6010502@suse.de> (from afaerber@suse.de on Thu Jun 6 06:44:31 2013) Message-ID: <1370536310.21533.7@snotra> MIME-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; delsp=Yes; format=Flowed Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] e600 core for MPC86xx processors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Andreas =?iso-8859-1?q?F=E4rber?= Cc: Julio Guerra , Stuart Yoder , qemu-ppc@nongnu.org, qemu-devel@nongnu.org, Alexander Graf On 06/06/2013 06:44:31 AM, Andreas F=E4rber wrote: > Am 26.05.2013 19:41, schrieb Julio Guerra: > > MPC86xx processors are based on the e600 core, which is not the case > > in qemu where it is based on the 7400 processor. > > > > This patch creates the e600 core and instantiates the MPC86xx > > processors based on it. Therefore, adding the high BATs and the SPRG > > 4..7 registers, which are e600-specific [1]. > > > > This allows to define the MPC8610 processor too and my program =20 > running > > on a real MPC8610 target is now able to run on qemu :) > > > > [1] =20 > http://cache.freescale.com/files/32bit/doc/ref_manual/E600CORERM.pdf > > > > Signed-off-by: Julio Guerra > > --- > > target-ppc/cpu-models.c | 10 ++-- > > target-ppc/cpu-models.h | 4 +- > > target-ppc/translate_init.c | 122 =20 > ++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 127 insertions(+), 9 deletions(-) >=20 > >From a technical (QOM) view this patch looks fine. >=20 > However I can't judge whether all that code is right for e600 and > whether you may want to share some code with e500 / e5500 in some way? > CC'ing some Freescale folks. e600 is a very different core from e500/e5500. It is a 74xx =20 derivative. The only thing I can see that could be shared with e500 is =20 the code to register SPRG4-7, but that's something that's already =20 duplicated between a bunch of cores. -Scott=