From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57453) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkvKT-0001n6-II for qemu-devel@nongnu.org; Fri, 07 Jun 2013 07:59:41 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkvKP-0004Ny-5L for qemu-devel@nongnu.org; Fri, 07 Jun 2013 07:59:37 -0400 Received: from mx1.redhat.com ([209.132.183.28]:18080) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkvKO-0004Nn-Tx for qemu-devel@nongnu.org; Fri, 07 Jun 2013 07:59:33 -0400 From: Stefan Hajnoczi Date: Fri, 7 Jun 2013 13:58:38 +0200 Message-Id: <1370606325-10680-20-git-send-email-stefanha@redhat.com> In-Reply-To: <1370606325-10680-1-git-send-email-stefanha@redhat.com> References: <1370606325-10680-1-git-send-email-stefanha@redhat.com> Subject: [Qemu-devel] [PULL 19/26] ide-test: Add enum value for DEV List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Kevin Wolf , Anthony Liguori , Stefan Hajnoczi From: Kevin Wolf Get rid of the magic number. Signed-off-by: Kevin Wolf Signed-off-by: Stefan Hajnoczi --- tests/ide-test.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/ide-test.c b/tests/ide-test.c index 365e995..1c31a2e 100644 --- a/tests/ide-test.c +++ b/tests/ide-test.c @@ -64,6 +64,7 @@ enum { }; enum { + DEV = 0x10, LBA = 0x40, }; @@ -394,7 +395,7 @@ static void test_identify(void) /* Read in the IDENTIFY buffer and check registers */ data = inb(IDE_BASE + reg_device); - g_assert_cmpint(data & 0x10, ==, 0); + g_assert_cmpint(data & DEV, ==, 0); for (i = 0; i < 256; i++) { data = inb(IDE_BASE + reg_status); -- 1.8.1.4