From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45125) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwHb-0004me-St for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:00:45 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UkwHX-0000Eh-NA for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:00:43 -0400 Received: from oxygen.pond.sub.org ([2a01:4f8:121:10e4::3]:45313) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UkwHX-0000Ea-HN for qemu-devel@nongnu.org; Fri, 07 Jun 2013 09:00:39 -0400 From: Markus Armbruster Date: Fri, 7 Jun 2013 15:00:36 +0200 Message-Id: <1370610036-10577-7-git-send-email-armbru@redhat.com> In-Reply-To: <1370610036-10577-1-git-send-email-armbru@redhat.com> References: <1370610036-10577-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH v2 6/6] smbios: Check R in -smbios type=0, release=R parses okay List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: aliguori@us.ibm.com, lersek@redhat.com Signed-off-by: Markus Armbruster --- hw/i386/smbios.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/i386/smbios.c b/hw/i386/smbios.c index 6431dd4..e708cb8 100644 --- a/hw/i386/smbios.c +++ b/hw/i386/smbios.c @@ -140,7 +140,10 @@ static void smbios_build_type_0_fields(const char *t) bios_release_date_str), buf, strlen(buf) + 1); if (get_param_value(buf, sizeof(buf), "release", t)) { - sscanf(buf, "%hhu.%hhu", &major, &minor); + if (sscanf(buf, "%hhu.%hhu", &major, &minor) != 2) { + error_report("Invalid release"); + exit(1); + } smbios_add_field(0, offsetof(struct smbios_type_0, system_bios_major_release), &major, 1); -- 1.7.11.7