From: "Jason J. Herne" <jjherne@us.ibm.com>
To: agraf@suse.de, borntraeger@de.ibm.com, jfrei@linux.vnet.ibm.com,
imammedo@redhat.com, qemu-devel@nongnu.org, ehabkost@redhat.com
Cc: "Jason J. Herne" <jjherne@us.ibm.com>
Subject: [Qemu-devel] [PATCH 4/8] [PATCH RFC v2] s390-qemu: cpu hotplug - ipi_states enhancements
Date: Fri, 7 Jun 2013 13:28:03 -0400 [thread overview]
Message-ID: <1370626087-840-5-git-send-email-jjherne@us.ibm.com> (raw)
In-Reply-To: <1370626087-840-1-git-send-email-jjherne@us.ibm.com>
From: "Jason J. Herne" <jjherne@us.ibm.com>
Modify s390_cpu_addr2state to allow fetching state information for cpu addresses
above the number of online cpus. Hotplug requires this capability.
Also add s390_cpu_set_state function to allow modification of ipi_state entries
during hotplug.
Finally, add function to find lowest unused ipi_state.
Signed-off-by: Jason J. Herne <jjherne@us.ibm.com>
---
hw/s390x/s390-virtio.c | 19 ++++++++++++++++---
target-s390x/cpu.h | 2 ++
2 files changed, 18 insertions(+), 3 deletions(-)
diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390-virtio.c
index 30d1118..ef4f1ae 100644
--- a/hw/s390x/s390-virtio.c
+++ b/hw/s390x/s390-virtio.c
@@ -54,13 +54,26 @@
static VirtIOS390Bus *s390_bus;
static S390CPU **ipi_states;
+void s390_cpu_set_state(uint16_t cpu_addr, S390CPU *state)
+{
+ ipi_states[cpu_addr] = state;
+}
+
S390CPU *s390_cpu_addr2state(uint16_t cpu_addr)
{
- if (cpu_addr >= smp_cpus) {
- return NULL;
+ return ipi_states[cpu_addr];
+}
+
+uint16_t s390_cpu_get_free_state_idx(void)
+{
+ int i;
+ for (i = 0; i < max_cpus; i++)
+ if (ipi_states[i] == NULL) {
+ return i;
}
- return ipi_states[cpu_addr];
+ assert(0); /* BUG! */
+ return -1;
}
static int s390_virtio_hcall_notify(const uint64_t *args)
diff --git a/target-s390x/cpu.h b/target-s390x/cpu.h
index 6304c4d..029d0c5 100644
--- a/target-s390x/cpu.h
+++ b/target-s390x/cpu.h
@@ -388,6 +388,8 @@ static inline void kvm_s390_interrupt_internal(S390CPU *cpu, int type,
}
#endif
S390CPU *s390_cpu_addr2state(uint16_t cpu_addr);
+void s390_cpu_set_state(uint16_t cpu_addr, S390CPU *state);
+uint16_t s390_cpu_get_free_state_idx(void);
void s390_add_running_cpu(S390CPU *cpu);
unsigned s390_del_running_cpu(S390CPU *cpu);
--
1.7.10.4
next prev parent reply other threads:[~2013-06-07 17:28 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 17:27 [Qemu-devel] [PATCH 0/8] [PATCH RFC v2] s390-qemu: cpu hotplug Jason J. Herne
2013-06-07 17:28 ` [Qemu-devel] [PATCH 1/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Define New SCLP Codes Jason J. Herne
2013-06-07 17:28 ` [Qemu-devel] [PATCH 2/8] [PATCH RFC v2] s390-qemu: cpu hotplug - SCLP CPU Info Jason J. Herne
2013-06-07 17:28 ` [Qemu-devel] [PATCH 3/8] [PATCH RFC v2] s390-qemu: cpu hotplug - SCLP Event integration Jason J. Herne
2013-06-07 17:28 ` Jason J. Herne [this message]
2013-06-07 17:28 ` [Qemu-devel] [PATCH 5/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Introduce post-cpu-init function Jason J. Herne
2013-06-08 22:10 ` Andreas Färber
2013-06-10 15:28 ` Jason J. Herne
2013-06-07 17:28 ` [Qemu-devel] [PATCH 6/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Storage key Global Access Jason J. Herne
2013-06-07 17:28 ` [Qemu-devel] [PATCH 7/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Infrastructure for Cpu Devices Jason J. Herne
2013-06-08 22:50 ` Andreas Färber
2013-06-10 16:00 ` Jason J. Herne
2013-07-30 7:59 ` Igor Mammedov
2013-06-07 17:28 ` [Qemu-devel] [PATCH 8/8] [PATCH RFC v2] s390-qemu: cpu hotplug - Treat S390 cpus as devices Jason J. Herne
2013-06-09 1:11 ` Andreas Färber
2013-06-10 9:02 ` Cornelia Huck
2013-06-10 16:49 ` Jason J. Herne
2013-07-29 19:41 ` Jason J. Herne
2013-07-30 7:24 ` Igor Mammedov
2013-07-30 14:27 ` Jason J. Herne
2013-07-30 14:50 ` Igor Mammedov
2013-07-30 14:58 ` Andreas Färber
2013-07-30 7:42 ` Igor Mammedov
2013-06-13 8:50 ` [Qemu-devel] [PATCH 0/8] [PATCH RFC v2] s390-qemu: cpu hotplug Christian Borntraeger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370626087-840-5-git-send-email-jjherne@us.ibm.com \
--to=jjherne@us.ibm.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).