qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Andreas Färber" <afaerber@suse.de>
To: qemu-devel@nongnu.org
Cc: "Michael S. Tsirkin" <mst@redhat.com>,
	jlarrew@linux.vnet.ibm.com, anthony@codemonkey.ws,
	"Paolo Bonzini" <pbonzini@redhat.com>,
	"Andreas Färber" <afaerber@suse.de>,
	fred.konrad@greensocs.com
Subject: [Qemu-devel] [PATCH RFT 0/5] QOM realize for virtio
Date: Fri,  7 Jun 2013 20:18:55 +0200	[thread overview]
Message-ID: <1370629140-30841-1-git-send-email-afaerber@suse.de> (raw)

Hello,

This series converts virtio devices to QOM realize/unrealize.
It is intended as base for fixing virtio-net initialization order issues,
as reported by Jesse. Only partially tested though.

Note that while VirtioDevice was setting a DeviceClass::exit callback
for cleaning up the bus name, this was overwritten by most derived classes.
That is fixed as part of this conversion.

Similarly, virtio_scsi_common_{init,exit} can be moved to VirtIOSCSICommon now.
This has the side-effect that the two SCSI subclasses now perform some
initializations after the common SCSI implementation has invoked
virtio_bus_plug_device().

As a follow-up, VirtIOSerialPort is also converted to QOM realize/unrealize.
As a side-effect, virtio-console realization is changed from in-order to pre-order.

Incidentally I stumbled over a minor cleanup issue with virtserialport.

Available from:
https://github.com/afaerber/qemu-cpu/commits/realize-virtio.v1
git://github.com/afaerber/qemu-cpu.git realize-virtio.v1

Regards,
Andreas

Cc: Anthony Liguori <anthony@codemonkey.ws>
Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Michael S. Tsirkin <mst@redhat.com>
Cc: Jesse Larrew <jlarrew@linux.vnet.ibm.com>
Cc: Frederic Konrad <fred.konrad@greensocs.com>

Andreas Färber (5):
  virtio-blk-dataplane: Improve error reporting
  virtio: Convert VirtioDevice to QOM realize/unrealize
  virtio-console: QOM'ify VirtConsole
  virtio-console: Use exitfn for virtserialport, too
  virtio-serial-port: Convert to QOM realize/unrealize

 hw/9pfs/virtio-9p-device.c         | 67 ++++++++++++++------------
 hw/9pfs/virtio-9p.h                | 13 +++++
 hw/block/dataplane/virtio-blk.c    | 25 +++++-----
 hw/block/dataplane/virtio-blk.h    |  5 +-
 hw/block/virtio-blk.c              | 56 +++++++++++++--------
 hw/char/virtio-console.c           | 99 ++++++++++++++++++++++++++------------
 hw/char/virtio-serial-bus.c        | 94 ++++++++++++++++++------------------
 hw/net/virtio-net.c                | 48 ++++++++++--------
 hw/scsi/vhost-scsi.c               | 59 +++++++++++++----------
 hw/scsi/virtio-scsi.c              | 85 ++++++++++++++++++++------------
 hw/virtio/virtio-balloon.c         | 50 +++++++++++--------
 hw/virtio/virtio-rng.c             | 53 +++++++++++---------
 hw/virtio/virtio.c                 | 20 +++-----
 include/hw/virtio/vhost-scsi.h     | 13 +++++
 include/hw/virtio/virtio-balloon.h | 13 +++++
 include/hw/virtio/virtio-blk.h     | 13 +++++
 include/hw/virtio/virtio-net.h     | 13 +++++
 include/hw/virtio/virtio-rng.h     | 13 +++++
 include/hw/virtio/virtio-scsi.h    | 29 +++++++++--
 include/hw/virtio/virtio-serial.h  | 24 ++++-----
 include/hw/virtio/virtio.h         |  6 ++-
 21 files changed, 513 insertions(+), 285 deletions(-)

-- 
1.8.1.4

             reply	other threads:[~2013-06-07 18:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07 18:18 Andreas Färber [this message]
2013-06-07 18:18 ` [Qemu-devel] [PATCH RFT 1/5] virtio-blk-dataplane: Improve error reporting Andreas Färber
2013-06-10 11:39   ` Stefan Hajnoczi
2013-07-29 20:19     ` Andreas Färber
2013-06-07 18:18 ` [Qemu-devel] [PATCH RFT 2/5] virtio: Convert VirtioDevice to QOM realize/unrealize Andreas Färber
2013-06-08  2:22   ` Peter Crosthwaite
2013-06-08  9:55     ` Andreas Färber
2013-06-08 12:32       ` Peter Crosthwaite
2013-06-10  2:08         ` Anthony Liguori
2013-06-10  6:30           ` Michael S. Tsirkin
2013-06-12  9:15           ` Andreas Färber
2013-06-13  1:48             ` Peter Crosthwaite
2013-06-18  9:57             ` Peter Crosthwaite
2013-06-09 10:36   ` Michael S. Tsirkin
2013-06-07 18:18 ` [Qemu-devel] [PATCH RFT 3/5] virtio-console: QOM'ify VirtConsole Andreas Färber
2013-06-07 18:18 ` [Qemu-devel] [PATCH RFT 4/5] virtio-console: Use exitfn for virtserialport, too Andreas Färber
2013-07-29 23:25   ` Andreas Färber
2013-06-07 18:19 ` [Qemu-devel] [PATCH RFT 5/5] virtio-serial-port: Convert to QOM realize/unrealize Andreas Färber
2013-06-09 10:39 ` [Qemu-devel] [PATCH RFT 0/5] QOM realize for virtio Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1370629140-30841-1-git-send-email-afaerber@suse.de \
    --to=afaerber@suse.de \
    --cc=anthony@codemonkey.ws \
    --cc=fred.konrad@greensocs.com \
    --cc=jlarrew@linux.vnet.ibm.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).