From: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, phrdina@redhat.com,
Wenchao Xia <xiawenc@linux.vnet.ibm.com>,
armbru@redhat.com, lcapitulino@redhat.com, stefanha@redhat.com,
pbonzini@redhat.com, dietmar@proxmox.com
Subject: [Qemu-devel] [PATCH 11/11] hmp: add interface hmp_snapshot_delete_internal_blkdev
Date: Sat, 8 Jun 2013 14:58:07 +0800 [thread overview]
Message-ID: <1370674687-13849-12-git-send-email-xiawenc@linux.vnet.ibm.com> (raw)
In-Reply-To: <1370674687-13849-1-git-send-email-xiawenc@linux.vnet.ibm.com>
Signed-off-by: Wenchao Xia <xiawenc@linux.vnet.ibm.com>
---
hmp-commands.hx | 19 +++++++++++++++++++
hmp.c | 10 ++++++++++
hmp.h | 1 +
3 files changed, 30 insertions(+), 0 deletions(-)
diff --git a/hmp-commands.hx b/hmp-commands.hx
index 65fb94d..9d9229c 100644
--- a/hmp-commands.hx
+++ b/hmp-commands.hx
@@ -1060,6 +1060,25 @@ Take an internal snapshot on device if it support
ETEXI
{
+ .name = "snapshot_delete_internal_blkdev",
+ .args_type = "device:B,name:s",
+ .params = "device name",
+ .help = "delete an internal snapshot of device.\n\t\t\t"
+ "Name is the snapshot's name.\n\t\t\t"
+ "If no snapshot matching name found,\n\t\t\t"
+ "the operation will fail.\n\t\t\t"
+ "The format of the image used by device must\n\t\t\t"
+ "support it, such as qcow2.\n\t\t\t",
+ .mhandler.cmd = hmp_snapshot_delete_internal_blkdev,
+ },
+
+STEXI
+@item snapshot_delete_internal_blkdev
+@findex snapshot_delete_internal_blkdev
+Delete an internal snapshot on device if it support
+ETEXI
+
+ {
.name = "drive_mirror",
.args_type = "reuse:-n,full:-f,device:B,target:s,format:s?",
.params = "[-n] [-f] device target [format]",
diff --git a/hmp.c b/hmp.c
index 810e4c5..1de6d25 100644
--- a/hmp.c
+++ b/hmp.c
@@ -922,6 +922,16 @@ void hmp_snapshot_internal_blkdev(Monitor *mon, const QDict *qdict)
hmp_handle_error(mon, &errp);
}
+void hmp_snapshot_delete_internal_blkdev(Monitor *mon, const QDict *qdict)
+{
+ const char *device = qdict_get_str(qdict, "device");
+ const char *name = qdict_get_try_str(qdict, "name");
+ Error *errp = NULL;
+
+ qmp_blockdev_snapshot_delete_internal_sync(device, name, &errp);
+ hmp_handle_error(mon, &errp);
+}
+
void hmp_migrate_cancel(Monitor *mon, const QDict *qdict)
{
qmp_migrate_cancel(NULL);
diff --git a/hmp.h b/hmp.h
index e7593e9..a562bf1 100644
--- a/hmp.h
+++ b/hmp.h
@@ -55,6 +55,7 @@ void hmp_balloon(Monitor *mon, const QDict *qdict);
void hmp_block_resize(Monitor *mon, const QDict *qdict);
void hmp_snapshot_blkdev(Monitor *mon, const QDict *qdict);
void hmp_snapshot_internal_blkdev(Monitor *mon, const QDict *qdict);
+void hmp_snapshot_delete_internal_blkdev(Monitor *mon, const QDict *qdict);
void hmp_drive_mirror(Monitor *mon, const QDict *qdict);
void hmp_migrate_cancel(Monitor *mon, const QDict *qdict);
void hmp_migrate_set_downtime(Monitor *mon, const QDict *qdict);
--
1.7.1
prev parent reply other threads:[~2013-06-08 7:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 6:57 [Qemu-devel] [PATCH 00/11] add internal snapshot support at block device level Wenchao Xia
2013-06-08 6:57 ` [Qemu-devel] [PATCH 01/11] blockdev: drop redundant proto_drv check Wenchao Xia
2013-06-08 6:57 ` [Qemu-devel] [PATCH 02/11] blockdev: rename BlkTransactionStates to singular Wenchao Xia
2013-06-08 6:57 ` [Qemu-devel] [PATCH 03/11] blockdev: allow BdrvActionOps->commit() to be NULL Wenchao Xia
2013-06-08 6:58 ` [Qemu-devel] [PATCH 04/11] snapshot: new function bdrv_snapshot_find_by_id_and_name() Wenchao Xia
2013-06-08 7:31 ` Fam Zheng
2013-06-08 7:58 ` Wenchao Xia
2013-06-08 8:35 ` Fam Zheng
2013-06-09 2:33 ` Wenchao Xia
2013-06-11 8:26 ` Stefan Hajnoczi
2013-06-13 3:34 ` Wenchao Xia
2013-06-08 6:58 ` [Qemu-devel] [PATCH 05/11] snapshot: add paired functions for internal snapshot id and name Wenchao Xia
2013-06-11 9:14 ` Stefan Hajnoczi
2013-06-13 5:33 ` Wenchao Xia
2013-06-13 8:30 ` Stefan Hajnoczi
2013-06-08 6:58 ` [Qemu-devel] [PATCH 06/11] snapshot: distinguish id and name in snapshot delete Wenchao Xia
2013-06-08 7:54 ` Fam Zheng
2013-06-11 9:25 ` Stefan Hajnoczi
2013-06-13 5:41 ` Wenchao Xia
2013-06-08 6:58 ` [Qemu-devel] [PATCH 07/11] qmp: add internal snapshot support in qmp_transaction Wenchao Xia
2013-06-08 6:58 ` [Qemu-devel] [PATCH 08/11] qmp: add interface blockdev-snapshot-internal-sync Wenchao Xia
2013-06-08 8:05 ` Fam Zheng
2013-06-09 2:35 ` Wenchao Xia
2013-06-08 6:58 ` [Qemu-devel] [PATCH 09/11] qmp: add interface blockdev-snapshot-delete-internal-sync Wenchao Xia
2013-06-08 6:58 ` [Qemu-devel] [PATCH 10/11] hmp: add interface hmp_snapshot_internal_blkdev Wenchao Xia
2013-06-08 8:21 ` Fam Zheng
2013-06-09 2:39 ` Wenchao Xia
2013-06-09 3:01 ` Fam Zheng
2013-06-08 6:58 ` Wenchao Xia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370674687-13849-12-git-send-email-xiawenc@linux.vnet.ibm.com \
--to=xiawenc@linux.vnet.ibm.com \
--cc=armbru@redhat.com \
--cc=dietmar@proxmox.com \
--cc=kwolf@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=phrdina@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).