From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49184) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlmTU-0000CN-Bw for qemu-devel@nongnu.org; Sun, 09 Jun 2013 16:44:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UlmTT-0000xQ-GW for qemu-devel@nongnu.org; Sun, 09 Jun 2013 16:44:28 -0400 Received: from qemu.weilnetz.de ([37.221.198.45]:51059 helo=v2201305906712890.yourvserver.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UlmTT-0000xH-AT for qemu-devel@nongnu.org; Sun, 09 Jun 2013 16:44:27 -0400 From: Stefan Weil Date: Sun, 9 Jun 2013 22:44:22 +0200 Message-Id: <1370810662-32320-1-git-send-email-sw@weilnetz.de> Subject: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Chubb Cc: Stefan Weil , qemu-devel cppcheck detected a condition which was always false. According to the MCIMX31 Reference Manual, the PRCS bits have to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2, so we have to test for 2. Signed-off-by: Stefan Weil --- hw/misc/imx_ccm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c index c153a24..427ce5c 100644 --- a/hw/misc/imx_ccm.c +++ b/hw/misc/imx_ccm.c @@ -153,7 +153,7 @@ static void update_clocks(IMXCCMState *s) * approach */ - if ((s->ccmr & CCMR_PRCS) == 1) { + if ((s->ccmr & CCMR_PRCS) == 2) { s->pll_refclk_freq = CKIL_FREQ * 1024; } else { s->pll_refclk_freq = CKIH_FREQ; -- 1.7.10.4