* [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test
@ 2013-06-09 20:44 Stefan Weil
2013-06-09 23:20 ` Peter Chubb
2013-06-25 17:43 ` Peter Maydell
0 siblings, 2 replies; 3+ messages in thread
From: Stefan Weil @ 2013-06-09 20:44 UTC (permalink / raw)
To: Peter Chubb; +Cc: Stefan Weil, qemu-devel
cppcheck detected a condition which was always false.
According to the MCIMX31 Reference Manual, the PRCS bits have to be 01
to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2,
so we have to test for 2.
Signed-off-by: Stefan Weil <sw@weilnetz.de>
---
hw/misc/imx_ccm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/imx_ccm.c b/hw/misc/imx_ccm.c
index c153a24..427ce5c 100644
--- a/hw/misc/imx_ccm.c
+++ b/hw/misc/imx_ccm.c
@@ -153,7 +153,7 @@ static void update_clocks(IMXCCMState *s)
* approach
*/
- if ((s->ccmr & CCMR_PRCS) == 1) {
+ if ((s->ccmr & CCMR_PRCS) == 2) {
s->pll_refclk_freq = CKIL_FREQ * 1024;
} else {
s->pll_refclk_freq = CKIH_FREQ;
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test
2013-06-09 20:44 [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test Stefan Weil
@ 2013-06-09 23:20 ` Peter Chubb
2013-06-25 17:43 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Chubb @ 2013-06-09 23:20 UTC (permalink / raw)
To: Stefan Weil; +Cc: Peter Chubb, qemu-devel
>>>>> "Stefan" == Stefan Weil <sw@weilnetz.de> writes:
Stefan> cppcheck detected a condition which was always false.
Stefan> According to the MCIMX31 Reference Manual, the PRCS bits have
Stefan> to be 01 to select the Frequency Pre-Multiplier (FPM). PRCS
Stefan> uses bits 1 and 2, so we have to test for 2.
Good catch. I hate hard coded constants, they're so easy to get wrong!
Stefan> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Signed-off-by: Peter Chubb <peter.chubb@nicta.com.au>
--
Dr Peter Chubb peter.chubb AT nicta.com.au
http://www.ssrg.nicta.com.au Software Systems Research Group/NICTA
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test
2013-06-09 20:44 [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test Stefan Weil
2013-06-09 23:20 ` Peter Chubb
@ 2013-06-25 17:43 ` Peter Maydell
1 sibling, 0 replies; 3+ messages in thread
From: Peter Maydell @ 2013-06-25 17:43 UTC (permalink / raw)
To: Stefan Weil; +Cc: Peter Chubb, qemu-devel
On 9 June 2013 21:44, Stefan Weil <sw@weilnetz.de> wrote:
> cppcheck detected a condition which was always false.
>
> According to the MCIMX31 Reference Manual, the PRCS bits have to be 01
> to select the Frequency Pre-Multiplier (FPM). PRCS uses bits 1 and 2,
> so we have to test for 2.
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Thanks, applied to arm-devs.next.
-- PMM
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-25 17:44 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-09 20:44 [Qemu-devel] [PATCH] i.MX31: Fix PRCS bit test Stefan Weil
2013-06-09 23:20 ` Peter Chubb
2013-06-25 17:43 ` Peter Maydell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).