[Qemu-devel] [PATCH v2] curl: Don't set curl options on the handle just before it's going to be deleted.

[Qemu-devel] [PATCH v2] curl: Don't set curl options on the handle just before it's going to be deleted.

[Richard W.M. Jones]

From: "Richard W.M. Jones" <rjones@redhat.com>

(Found by Kamil Dudka)

Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
Cc: Michael Tokarev <mjt@tls.msk.ru>
---
 block/curl.c | 2 --
 1 file changed, 2 deletions(-)

diff --git a/block/curl.c b/block/curl.c
index b634ccf..8d0d45d 100644
--- a/block/curl.c
+++ b/block/curl.c
@@ -452,8 +452,6 @@ static int curl_open(BlockDriverState *bs, QDict *options, int flags)
     if (curl_easy_perform(state->curl))
         goto out;
     curl_easy_getinfo(state->curl, CURLINFO_CONTENT_LENGTH_DOWNLOAD, &d);
-    curl_easy_setopt(state->curl, CURLOPT_WRITEFUNCTION, (void *)curl_read_cb);
-    curl_easy_setopt(state->curl, CURLOPT_NOBODY, 0);
     if (d)
         s->len = (size_t)d;
     else if(!s->len)
-- 
1.8.2.1

Re: [Qemu-devel] [PATCH v2] curl: Don't set curl options on the handle just before it's going to be deleted.

[Stefan Hajnoczi]

On Mon, Jun 10, 2013 at 05:40:15PM +0100, Richard W.M. Jones wrote:
> From: "Richard W.M. Jones" <rjones@redhat.com>
> 
> (Found by Kamil Dudka)
> 
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> Cc: Michael Tokarev <mjt@tls.msk.ru>
> ---
>  block/curl.c | 2 --
>  1 file changed, 2 deletions(-)

Acked-by: Stefan Hajnoczi <stefanha@redhat.com>

Re: [Qemu-devel] [PATCH v2] curl: Don't set curl options on the handle just before it's going to be deleted.

[Kevin Wolf]

Am 10.06.2013 um 18:40 hat Richard W.M. Jones geschrieben:
> From: "Richard W.M. Jones" <rjones@redhat.com>
> 
> (Found by Kamil Dudka)
> 
> Signed-off-by: Richard W.M. Jones <rjones@redhat.com>
> Cc: Michael Tokarev <mjt@tls.msk.ru>

Thanks, applied to the block branch.

Kevin