From: Luiz Capitulino <lcapitulino@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, armbru@redhat.com, stefanha@redhat.com
Subject: [Qemu-devel] [PATCH 2/9] rng-random: use error_setg_file_open()
Date: Mon, 10 Jun 2013 13:02:21 -0400 [thread overview]
Message-ID: <1370883748-31439-3-git-send-email-lcapitulino@redhat.com> (raw)
In-Reply-To: <1370883748-31439-1-git-send-email-lcapitulino@redhat.com>
Signed-off-by: Luiz Capitulino <lcapitulino@redhat.com>
---
backends/rng-random.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/backends/rng-random.c b/backends/rng-random.c
index 830360c..68dfc8a 100644
--- a/backends/rng-random.c
+++ b/backends/rng-random.c
@@ -78,9 +78,8 @@ static void rng_random_opened(RngBackend *b, Error **errp)
"filename", "a valid filename");
} else {
s->fd = qemu_open(s->filename, O_RDONLY | O_NONBLOCK);
-
if (s->fd == -1) {
- error_set(errp, QERR_OPEN_FILE_FAILED, s->filename);
+ error_setg_file_open(errp, errno, s->filename);
}
}
}
--
1.8.1.4
next prev parent reply other threads:[~2013-06-10 17:02 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-10 17:02 [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures Luiz Capitulino
2013-06-10 17:02 ` [Qemu-devel] [PATCH 1/9] error: add error_setg_file_open() helper Luiz Capitulino
2013-06-10 17:02 ` Luiz Capitulino [this message]
2013-06-10 17:02 ` [Qemu-devel] [PATCH 3/9] block: mirror_complete(): use error_setg_file_open() Luiz Capitulino
2013-06-10 17:02 ` [Qemu-devel] [PATCH 4/9] blockdev: " Luiz Capitulino
2013-06-10 17:02 ` [Qemu-devel] [PATCH 5/9] cpus: " Luiz Capitulino
2013-06-10 17:02 ` [Qemu-devel] [PATCH 6/9] dump: qmp_dump_guest_memory(): " Luiz Capitulino
2013-06-10 17:02 ` [Qemu-devel] [PATCH 7/9] savevm: qmp_xen_save_devices_state(): " Luiz Capitulino
2013-06-10 17:02 ` [Qemu-devel] [PATCH 8/9] block: bdrv_reopen_prepare(): don't use QERR_OPEN_FILE_FAILED Luiz Capitulino
2013-06-11 8:38 ` Kevin Wolf
2013-06-11 12:32 ` Luiz Capitulino
2013-06-10 17:02 ` [Qemu-devel] [PATCH 9/9] qerror: drop QERR_OPEN_FILE_FAILED macro Luiz Capitulino
2013-06-11 7:43 ` [Qemu-devel] [PATCH v2 0/9] QMP/HMP: add error reason to open failures Stefan Hajnoczi
2013-06-11 7:44 ` Stefan Hajnoczi
2013-06-11 12:29 ` Luiz Capitulino
2013-06-11 8:40 ` Kevin Wolf
-- strict thread matches above, loose matches on Subject: below --
2013-06-07 19:52 [Qemu-devel] [PATCH " Luiz Capitulino
2013-06-07 19:52 ` [Qemu-devel] [PATCH 2/9] rng-random: use error_setg_file_open() Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1370883748-31439-3-git-send-email-lcapitulino@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).