* [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X
@ 2013-06-12 14:22 Kevin Wolf
2013-06-13 8:37 ` Stefan Hajnoczi
2013-06-13 10:42 ` Andreas Färber
0 siblings, 2 replies; 3+ messages in thread
From: Kevin Wolf @ 2013-06-12 14:22 UTC (permalink / raw)
To: qemu-devel; +Cc: kwolf, agraf, programmingkidx, qemu-stable, afaerber
The raw-posix driver has code to provide a /dev/cdrom on OS X even
though it doesn't really exist. However, since commit c66a6157 the real
filename is dismissed after finding it, so opening /dev/cdrom fails.
Put the filename back into the options QDict to make this work again.
Cc: qemu-stable@nongnu.org
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
block/raw-posix.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index c0ccf27..90ce9f8 100644
--- a/block/raw-posix.c
+++ b/block/raw-posix.c
@@ -1350,6 +1350,7 @@ static int hdev_open(BlockDriverState *bs, QDict *options, int flags)
qemu_close(fd);
}
filename = bsdPath;
+ qdict_put(options, "filename", qstring_from_str(filename));
}
if ( mediaIterator )
--
1.8.1.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X
2013-06-12 14:22 [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X Kevin Wolf
@ 2013-06-13 8:37 ` Stefan Hajnoczi
2013-06-13 10:42 ` Andreas Färber
1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2013-06-13 8:37 UTC (permalink / raw)
To: Kevin Wolf; +Cc: programmingkidx, qemu-stable, qemu-devel, afaerber, agraf
On Wed, Jun 12, 2013 at 04:22:52PM +0200, Kevin Wolf wrote:
> The raw-posix driver has code to provide a /dev/cdrom on OS X even
> though it doesn't really exist. However, since commit c66a6157 the real
> filename is dismissed after finding it, so opening /dev/cdrom fails.
> Put the filename back into the options QDict to make this work again.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/raw-posix.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X
2013-06-12 14:22 [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X Kevin Wolf
2013-06-13 8:37 ` Stefan Hajnoczi
@ 2013-06-13 10:42 ` Andreas Färber
1 sibling, 0 replies; 3+ messages in thread
From: Andreas Färber @ 2013-06-13 10:42 UTC (permalink / raw)
To: Kevin Wolf
Cc: qemu-devel, Peter Maydell, Stefan Hajnoczi, Alexander Graf,
Programmingkid
Am 12.06.2013 16:22, schrieb Kevin Wolf:
> The raw-posix driver has code to provide a /dev/cdrom on OS X even
> though it doesn't really exist. However, since commit c66a6157 the real
> filename is dismissed after finding it, so opening /dev/cdrom fails.
> Put the filename back into the options QDict to make this work again.
>
> Cc: qemu-stable@nongnu.org
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
> block/raw-posix.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/block/raw-posix.c b/block/raw-posix.c
> index c0ccf27..90ce9f8 100644
> --- a/block/raw-posix.c
> +++ b/block/raw-posix.c
> @@ -1350,6 +1350,7 @@ static int hdev_open(BlockDriverState *bs, QDict *options, int flags)
> qemu_close(fd);
> }
> filename = bsdPath;
> + qdict_put(options, "filename", qstring_from_str(filename));
> }
>
> if ( mediaIterator )
On Mac OS X v10.5.8 ppc64 I get:
qemu-system-x86_64: -cdrom /dev/cdrom: could not open disk image
/dev/cdrom: No such file or directory
On ppc I get a crash even without options, seems unrelated though.
Andreas
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-13 10:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2013-06-12 14:22 [Qemu-devel] [PATCH] raw-posix: Fix /dev/cdrom magic on OS X Kevin Wolf
2013-06-13 8:37 ` Stefan Hajnoczi
2013-06-13 10:42 ` Andreas Färber
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).